Page MenuHomePhabricator
Differential D5772

Refactor getAllMessages{Sync}. Bring db messages parsing to separate function
ClosedPublic
Actions

Authored by marcin on Nov 30 2022, 10:43 AM.
Tags
None
Referenced Files
Unknown Object (File)
Nov 22 2024, 6:45 AM
Unknown Object (File)
Nov 22 2024, 6:45 AM
Unknown Object (File)
Nov 22 2024, 6:45 AM
Unknown Object (File)
Nov 22 2024, 6:45 AM
Unknown Object (File)
Nov 22 2024, 6:39 AM
Unknown Object (File)
Nov 19 2024, 7:14 AM
Unknown Object (File)
Nov 19 2024, 12:15 AM
Unknown Object (File)
Nov 19 2024, 12:09 AM
View All Files
Subscribers
ashoat

Details

Reviewers
tomek
atul
• jon
Commits
rCOMM546b0af1a038: Refactor getAllMessages{Sync}. Bring db messages parsing to separate function
Summary

This differential brings db messages persing into separate function. This removes duplicated logic and allowes to perform exclusively db messages parsing when we implement JSI method to get all SQLite data.

Test Plan

Launhc the app, open chat with a certaion user so that messages are fetched from server. Kill the app, launch the app and flipper. Ensure messages are in the payload of SET_CLIENT_DB_STORE action.

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

marcin created this revision.Nov 30 2022, 10:43 AM
Herald added a reviewer: • jon. · View Herald TranscriptNov 30 2022, 10:43 AM
Herald added a subscriber: ashoat. · View Herald Transcript
marcin added a parent revision: D5771: Refactor getAllDrafts. Bring db drafts parsing to separate function.Nov 30 2022, 10:43 AM
Harbormaster returned this revision to the author for changes because remote builds failed.Nov 30 2022, 10:48 AM
Harbormaster failed remote builds in B13886: Diff 19019!
marcin added a child revision: D5773: Refactor getAllThreads{Sync}. Bring db threads parsing into separate function.Nov 30 2022, 10:49 AM
Harbormaster completed remote builds in B13886: Diff 19019.Nov 30 2022, 11:01 AM
marcin requested review of this revision.Nov 30 2022, 11:01 AM
tomek accepted this revision.Dec 1 2022, 5:59 AM

Great! I'm glad to see that copy-pasted code gets refactored!

This revision is now accepted and ready to land.Dec 1 2022, 5:59 AM
marcin updated this revision to Diff 19095.Dec 2 2022, 12:43 AM

Rebase before landing

Harbormaster completed remote builds in B13935: Diff 19095.Dec 2 2022, 12:55 AM
Closed by commit rCOMM546b0af1a038: Refactor getAllMessages{Sync}. Bring db messages parsing to separate function (authored by marcin). · Explain WhyDec 2 2022, 1:06 AM
This revision was automatically updated to reflect the committed changes.
marcin added a commit: rCOMM546b0af1a038: Refactor getAllMessages{Sync}. Bring db messages parsing to separate function.

Revision Contents
Changeset List

PathSize
native/
cpp/
CommonCpp/
NativeModules/
153 lines

Diff 19095

View Options

native/cpp/CommonCpp/NativeModules/CommCoreModule.cpp

Loading...