Two things here - the first is that we probably want to make the color of spoilers the same as it is on native, #33332C. The second thing is the current spoiler color on received messages is impossible to differentiate from the message bubble.
Details
Details
- Reviewers
atul tomek ginsu - Commits
- rCOMM9886de646f57: [web] Standardize spoiler color
Will link before/after on web
| Before | After |
 |  |
 |  |
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Branch
- web_spoiler_design
- Lint
No Lint Coverage - Unit
No Test Coverage
Event Timeline
Comment Actions
Looks good, thanks for including the screenshots in the Test Plan (everyone is doing these fancy markdown tables now huh)
Comment Actions
We should prefer using something from our existing color palette - the first section of this file. If we really have to introduce a new color, we should introduce it in the first section and use here.
Comment Actions
Thanks for pointing this out! I switched from var(--shades-black-80) to #33332c to keep the color consistent with native, and also more importantly to prevent the spoilers from blending in with other colors and making it difficult to see.
I can put up a super quick change for this if you think keeping #33332c is fine and move --spoiler-text-color: #33332c and --spoiler-background-color: #33332c up to after line 52
Comment Actions
There are a lot of options here, but most of them aren't worth it. A good enough solution for now might be to create a new variable, just as you suggested, and use it here.