Page MenuHomePhabricator

[native] Fix in-app notif on Android which system theme is dark
ClosedPublic

Authored by ashoat on Dec 17 2022, 6:59 PM.
Tags
None
Referenced Files
F3517885: D5892.id19455.diff
Sun, Dec 22, 6:27 PM
F3516314: D5892.diff
Sun, Dec 22, 1:42 PM
Unknown Object (File)
Nov 22 2024, 6:03 AM
Unknown Object (File)
Nov 22 2024, 6:03 AM
Unknown Object (File)
Nov 22 2024, 6:03 AM
Unknown Object (File)
Nov 22 2024, 6:02 AM
Unknown Object (File)
Nov 8 2024, 10:02 AM
Unknown Object (File)
Nov 6 2024, 6:24 AM
Subscribers

Details

Summary

On Android, we show the same design of in-app notif for both dark mode and light mode. (Unlike iOS, where we vary it.)

However, the default text color on Android depends on the system theme. As a result, if the system theme is dark, then we end up having a white text (default) appear in front of a white background.

This diff makes sure we always set the text color explicitly instead of relying on defaults.

Test Plan

Confirm in-app notif body text can be read

Diff Detail

Repository
rCOMM Comm
Branch
ashoat/rn70-upgrade-extras
Lint
No Lint Coverage
Unit
No Test Coverage