Page MenuHomePhabricator

[native] Fix in-app notif on Android which system theme is dark
ClosedPublic

Authored by ashoat on Dec 17 2022, 6:59 PM.
Tags
None
Referenced Files
F2899387: D5892.id19455.diff
Sat, Oct 5, 6:48 AM
Unknown Object (File)
Wed, Sep 25, 6:20 PM
Unknown Object (File)
Thu, Sep 19, 11:02 PM
Unknown Object (File)
Thu, Sep 19, 11:02 PM
Unknown Object (File)
Thu, Sep 19, 11:02 PM
Unknown Object (File)
Thu, Sep 19, 11:02 PM
Unknown Object (File)
Mon, Sep 9, 7:57 AM
Unknown Object (File)
Sep 4 2024, 10:51 PM
Subscribers

Details

Summary

On Android, we show the same design of in-app notif for both dark mode and light mode. (Unlike iOS, where we vary it.)

However, the default text color on Android depends on the system theme. As a result, if the system theme is dark, then we end up having a white text (default) appear in front of a white background.

This diff makes sure we always set the text color explicitly instead of relying on defaults.

Test Plan

Confirm in-app notif body text can be read

Diff Detail

Repository
rCOMM Comm
Branch
ashoat/rn70-upgrade-extras
Lint
No Lint Coverage
Unit
No Test Coverage