Paths

Table of Contentst

Differential D5872

[CI] Update android.yml to use protobuf 3.15
ClosedPublic
Actions

Authored by • jon on Dec 14 2022, 2:26 PM.

Tags

None

Referenced Files

	F3495415: D5872.diff
	Thu, Dec 19, 8:33 AM

	F3491116: D5872.id19551.diff
	Wed, Dec 18, 6:17 PM

	F3491115: D5872.id19358.diff
	Wed, Dec 18, 6:17 PM

	F3488681: D5872.id.diff
	Wed, Dec 18, 10:59 AM

	Unknown Object (File)
	Nov 10 2024, 5:59 PM

	Unknown Object (File)
	Nov 10 2024, 5:59 PM

	Unknown Object (File)
	Nov 10 2024, 5:59 PM

	Unknown Object (File)
	Nov 10 2024, 5:55 PM

Subscribers

Details

Reviewers

varun
• max

Commits

rCOMM37ed8facd69c: [CI] Update android.yml to use protobuf 3.15

Summary

Update buildkite yaml to use protobuf 3.15 through building it ourselves.

Part of https://linear.app/comm/issue/ENG-2404

Depends on D5861

Test Plan

https://buildkite.com/comm/android-ci-plus-protoc-install/builds/3#018512ba-527e-4f39-9553-7e3d371dee3b

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

• jon created this revision.Dec 14 2022, 2:26 PM

Herald added subscribers: atul, tomek, ashoat. · View Herald TranscriptDec 14 2022, 2:26 PM

• jon mentioned this in D5861: [Android] Add script to install protoc for CI.Dec 14 2022, 2:27 PM

Harbormaster completed remote builds in B14156: Diff 19358.Dec 14 2022, 2:39 PM

• jon requested review of this revision.Dec 14 2022, 2:39 PM

varun accepted this revision.Dec 16 2022, 9:45 AM

varun added inline comments.

.buildkite/android.yml
7 ↗	(On Diff #19358)	why are we installing all of these packages?

This revision is now accepted and ready to land.Dec 16 2022, 9:45 AM

• jon marked an inline comment as done.Dec 16 2022, 10:11 AM

• jon added inline comments.

.buildkite/android.yml
7 ↗	(On Diff #19358)	The `install_protobuf.sh` script is installing protobuf from source as the package set from ubuntu has an outdated version. `autoconf` and `libtool` might not be necessary (protobuf can also be installed using autotools); but the rest are necessary.

• max accepted this revision.Dec 16 2022, 10:41 AM

• jon marked an inline comment as done.Dec 19 2022, 6:33 AM

Closed by commit rCOMM37ed8facd69c: [CI] Update android.yml to use protobuf 3.15 (authored by • jon). · Explain WhyDec 19 2022, 6:35 AM

This revision was automatically updated to reflect the committed changes.

• jon added a commit: rCOMM37ed8facd69c: [CI] Update android.yml to use protobuf 3.15.

Revision Contents
Changeset List

Path

Size

.buildkite/

3 lines

Diff 19551

.buildkite/android.yml

Loading...