Differential D6016
[web] Prevent web Menu from dismissing itself on open Authored by ashoat on Dec 23 2022, 10:11 AM. Tags None Referenced Files
Subscribers None
Details Some change in React 18 is making document.addEventListener('click', closeMenuCallback) execute faster than before, and somehow it's able to catch the click that created it. Not sure how this is happening, but the fix is easy: stop the propagation of the click event once we handle it. This solves https://linear.app/comm/issue/ENG-2534/cant-press-three-dots-button-in-messagelist-on-web Make sure I can open the "three dots" menu in the MessageList on web
Diff Detail
Event TimelineComment Actions Should we check if there are other instances of document.addEventListener('click' to see if there might be additional issues? Comment Actions Good call. ashoat@ashoatmbp2021 [~/src/comm/web]$ git grep "'click'"
components/menu.react.js: document.addEventListener('click', closeMenuCallback);
components/menu.react.js: document.removeEventListener('click', closeMenuCallback);
ashoat@ashoatmbp2021 [~/src/comm/web]$ cd ../landing/
ashoat@ashoatmbp2021 [~/src/comm/landing]$ git grep "'click'"
ashoat@ashoatmbp2021 [~/src/comm/landing]$Looks like we're good! |