Page MenuHomePhabricator
Differential D6030

[lib] Introduce `SIWEMessage` type
ClosedPublic
Actions

Authored by atul on Dec 24 2022, 7:58 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Apr 10, 2:52 PM
Unknown Object (File)
Wed, Mar 19, 8:26 PM
Unknown Object (File)
Sat, Mar 15, 11:02 PM
Unknown Object (File)
Sat, Mar 15, 11:02 PM
Unknown Object (File)
Sat, Mar 15, 11:02 PM
Unknown Object (File)
Sat, Mar 15, 11:01 PM
Unknown Object (File)
Sat, Mar 15, 10:48 PM
Unknown Object (File)
Mar 13 2025, 9:16 AM
View All Files
Subscribers
None

Details

Reviewers
tomek
ashoat
Commits
rCOMMb443a8224f54: [lib] Introduce `SIWEMessage` type
Summary

Effectively copied from the TypeScript types:

8115ce.png (1×1 px, 391 KB)

Will be helpful to type return value of new SiweMessage(message) in siweAuthResponder as SIWEMessage.

Depends on D6029

Test Plan

Careful reading

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

atul created this revision.Dec 24 2022, 7:58 PM
atul edited the summary of this revision. (Show Details)Dec 24 2022, 8:01 PM
atul added a parent revision: D6029: [keyserver] Introduce `isValidEthereumAddress`.
atul added a child revision: D6031: [keyserver] Introduce `isValidSIWEMessage` and use it to validate `message` in `siweAuthResponder`.
atul edited the summary of this revision. (Show Details)
Harbormaster completed remote builds in B14740: Diff 20104.Dec 24 2022, 8:13 PM
atul requested review of this revision.Dec 24 2022, 8:13 PM
atul added a comment.EditedDec 25 2022, 12:28 AM

Will type the parts of siwe library we use properly w/ flow-typed in a subsequent diff once everything is working.

ashoat accepted this revision.Dec 25 2022, 7:25 PM
This revision is now accepted and ready to land.Dec 25 2022, 7:25 PM
atul updated this revision to Diff 20136.Dec 27 2022, 12:46 AM

rebase before landing

This revision was landed with ongoing or failed builds.Dec 27 2022, 12:47 AM
Closed by commit rCOMMb443a8224f54: [lib] Introduce `SIWEMessage` type (authored by atul). · Explain Why
This revision was automatically updated to reflect the committed changes.
atul added a commit: rCOMMb443a8224f54: [lib] Introduce `SIWEMessage` type.
Harbormaster completed remote builds in B14762: Diff 20136.Dec 27 2022, 1:00 AM

Revision Contents
Changeset List

PathSize
lib/
types/
63 lines

Diff 20104

View Options

lib/types/siwe-types.js

Show All 12 Lines
import { import {
createAsyncMigrate, createAsyncMigrate,
type StorageMigrationFunction, type StorageMigrationFunction,
} from 'lib/shared/create-async-migrate.js'; } from 'lib/shared/create-async-migrate.js';
import type { import type {
KeyserverInfo, KeyserverInfo,
KeyserverStore, KeyserverStore,
} from 'lib/types/keyserver-types.js'; } from 'lib/types/keyserver-types.js';
import { cookieTypes } from 'lib/types/session-types.js';
import { import {
defaultConnectionInfo, defaultConnectionInfo,
type ConnectionInfo, type ConnectionInfo,
} from 'lib/types/socket-types.js'; } from 'lib/types/socket-types.js';
import { parseCookies } from 'lib/utils/cookie-utils.js';
import { isDev } from 'lib/utils/dev-utils.js'; import { isDev } from 'lib/utils/dev-utils.js';
import { import {
generateIDSchemaMigrationOpsForDrafts, generateIDSchemaMigrationOpsForDrafts,
convertDraftStoreToNewIDSchema, convertDraftStoreToNewIDSchema,
} from 'lib/utils/migration-utils.js'; } from 'lib/utils/migration-utils.js';
import { ashoatKeyserverID } from 'lib/utils/validation-utils.js'; import { ashoatKeyserverID } from 'lib/utils/validation-utils.js';
import commReduxStorageEngine from './comm-redux-storage-engine.js'; import commReduxStorageEngine from './comm-redux-storage-engine.js';
▲ Show 20 Lines • Show All 92 Lines • ▼ Show 20 Lines [5]: async state => {
await databaseModule.schedule({ await databaseModule.schedule({
type: workerRequestMessageTypes.PROCESS_STORE_OPERATIONS, type: workerRequestMessageTypes.PROCESS_STORE_OPERATIONS,
storeOperations: { draftStoreOperations }, storeOperations: { draftStoreOperations },
}); });
return state; return state;
}, },
[6]: async (state: AppState): Promise<AppState> => {
const params = parseCookies(document.cookie);
let cookie = null;
if (params[cookieTypes.USER]) {
cookie = `${cookieTypes.USER}=${params[cookieTypes.USER]}`;
} else if (params[cookieTypes.ANONYMOUS]) {
cookie = `${cookieTypes.ANONYMOUS}=${params[cookieTypes.ANONYMOUS]}`;
}
return {
...state,
keyserverStore: {
...state.keyserverStore,
keyserverInfos: {
...state.keyserverStore.keyserverInfos,
[ashoatKeyserverID]: {
...state.keyserverStore.keyserverInfos[ashoatKeyserverID],
cookie,
},
},
},
};
},
}; };
const persistWhitelist = [ const persistWhitelist = [
'enabledApps', 'enabledApps',
'deviceID', 'deviceID',
'cryptoStore', 'cryptoStore',
'notifPermissionAlertInfo', 'notifPermissionAlertInfo',
'commServicesAccessToken', 'commServicesAccessToken',
▲ Show 20 Lines • Show All 96 Lines • ▼ Show 20 Linesconst persistConfig: PersistConfig = {
whitelist: isSQLiteSupported() whitelist: isSQLiteSupported()
? persistWhitelist ? persistWhitelist
: [...persistWhitelist, 'draftStore'], : [...persistWhitelist, 'draftStore'],
migrate: (createAsyncMigrate( migrate: (createAsyncMigrate(
migrations, migrations,
{ debug: isDev }, { debug: isDev },
migrateStorageToSQLite, migrateStorageToSQLite,
): any), ): any),
version: 5, version: 6,
transforms: [keyserverStoreTransform], transforms: [keyserverStoreTransform],
}; };
export { persistConfig }; export { persistConfig };