[lib] Introduce `SIWEMessage` type
ClosedPublic
Actions

Authored by atul on Dec 24 2022, 7:58 PM.

Details

Reviewers

tomek
ashoat

Commits

rCOMMb443a8224f54: [lib] Introduce `SIWEMessage` type

Summary

Effectively copied from the TypeScript types:

Will be helpful to type return value of new SiweMessage(message) in siweAuthResponder as SIWEMessage.

Depends on D6029

Test Plan

Careful reading

Diff Detail

Repository

rCOMM Comm

Branch

arcpatch-D6030 (branched from master)

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

atul created this revision.Dec 24 2022, 7:58 PM

atul edited the summary of this revision. (Show Details)Dec 24 2022, 8:01 PM

atul added a parent revision: D6029: [keyserver] Introduce `isValidEthereumAddress`.

atul added a child revision: D6031: [keyserver] Introduce `isValidSIWEMessage` and use it to validate `message` in `siweAuthResponder`.

atul edited the summary of this revision. (Show Details)

Harbormaster completed remote builds in B14740: Diff 20104.Dec 24 2022, 8:13 PM

atul requested review of this revision.Dec 24 2022, 8:13 PM

Will type the parts of siwe library we use properly w/ flow-typed in a subsequent diff once everything is working.

ashoat accepted this revision.Dec 25 2022, 7:25 PM

This revision is now accepted and ready to land.Dec 25 2022, 7:25 PM

rebase before landing

This revision was landed with ongoing or failed builds.Dec 27 2022, 12:47 AM

Closed by commit rCOMMb443a8224f54: [lib] Introduce `SIWEMessage` type (authored by atul). · Explain Why

This revision was automatically updated to reflect the committed changes.

atul added a commit: rCOMMb443a8224f54: [lib] Introduce `SIWEMessage` type.

Harbormaster completed remote builds in B14762: Diff 20136.Dec 27 2022, 1:00 AM

Revision Contents
Changeset List

Path

Size

lib/

types/

siwe-types.js

63 lines

Diff 20136

View Options

[lib] Introduce `SIWEMessage` typeClosedPublicActions