Page MenuHomePhabricator
Differential D6030

[lib] Introduce `SIWEMessage` type
ClosedPublic
Actions

Authored by atul on Dec 24 2022, 7:58 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Nov 14, 5:37 AM
Unknown Object (File)
Wed, Nov 13, 5:22 AM
Unknown Object (File)
Fri, Nov 8, 4:18 PM
Unknown Object (File)
Fri, Nov 8, 4:18 PM
Unknown Object (File)
Fri, Nov 8, 4:18 PM
Unknown Object (File)
Fri, Nov 8, 3:49 PM
Unknown Object (File)
Fri, Nov 8, 3:48 PM
Unknown Object (File)
Thu, Nov 7, 5:34 PM
View All Files
Subscribers
None

Details

Reviewers
tomek
ashoat
Commits
rCOMMb443a8224f54: [lib] Introduce `SIWEMessage` type
Summary

Effectively copied from the TypeScript types:

8115ce.png (1×1 px, 391 KB)

Will be helpful to type return value of new SiweMessage(message) in siweAuthResponder as SIWEMessage.

Depends on D6029

Test Plan

Careful reading

Diff Detail

Repository
rCOMM Comm
Branch
arcpatch-D6030 (branched from master)
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

atul created this revision.Dec 24 2022, 7:58 PM
atul edited the summary of this revision. (Show Details)Dec 24 2022, 8:01 PM
atul added a parent revision: D6029: [keyserver] Introduce `isValidEthereumAddress`.
atul added a child revision: D6031: [keyserver] Introduce `isValidSIWEMessage` and use it to validate `message` in `siweAuthResponder`.
atul edited the summary of this revision. (Show Details)
Harbormaster completed remote builds in B14740: Diff 20104.Dec 24 2022, 8:13 PM
atul requested review of this revision.Dec 24 2022, 8:13 PM
atul added a comment.EditedDec 25 2022, 12:28 AM

Will type the parts of siwe library we use properly w/ flow-typed in a subsequent diff once everything is working.

ashoat accepted this revision.Dec 25 2022, 7:25 PM
This revision is now accepted and ready to land.Dec 25 2022, 7:25 PM
atul updated this revision to Diff 20136.Dec 27 2022, 12:46 AM

rebase before landing

This revision was landed with ongoing or failed builds.Dec 27 2022, 12:47 AM
Closed by commit rCOMMb443a8224f54: [lib] Introduce `SIWEMessage` type (authored by atul). · Explain Why
This revision was automatically updated to reflect the committed changes.
atul added a commit: rCOMMb443a8224f54: [lib] Introduce `SIWEMessage` type.
Harbormaster completed remote builds in B14762: Diff 20136.Dec 27 2022, 1:00 AM

Revision Contents
Changeset List

PathSize
lib/
types/
63 lines

Diff 20136

View Options

lib/types/siwe-types.js

Loading...