Page MenuHomePhabricator
Differential D6054

[lib/native] move useCanCreateReactionFromMessage hook from native to lib
ClosedPublic
Actions

Authored by ginsu on Dec 27 2022, 7:13 AM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Apr 18, 2:03 PM
Unknown Object (File)
Fri, Apr 18, 8:57 AM
Unknown Object (File)
Fri, Apr 18, 1:53 AM
Unknown Object (File)
Wed, Apr 16, 9:58 PM
Unknown Object (File)
Tue, Apr 15, 9:29 PM
Unknown Object (File)
Tue, Apr 15, 9:29 PM
Unknown Object (File)
Tue, Apr 15, 9:29 PM
Unknown Object (File)
Wed, Apr 9, 5:55 AM
View All Files
Subscribers
ashoat
atul
tomek

Details

Reviewers
tomek
atul
Commits
rCOMM2c8502862fe5: [lib/native] move useCanCreateReactionFromMessage hook from native to lib
Summary

Move useCanCreateReactionFromMessage hook into reaction-utils in lib so that both web and native can use this hook

Depends on D6005

Linear Task: ENG-2464

Test Plan

flow also ran app locally on native and nothing crashes

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

ginsu created this revision.Dec 27 2022, 7:13 AM
Herald added subscribers: atul, tomek, ashoat. · View Herald TranscriptDec 27 2022, 7:13 AM
ginsu edited the summary of this revision. (Show Details)Dec 27 2022, 7:14 AM
ginsu added reviewers: atul, tomek.
ginsu added a parent revision: D6005: [lib/keyserver/native] move all the reaction message types into its own file.
ginsu added a child revision: D6055: [web] introduce useOnClickReact hook in reaction message utils.Dec 27 2022, 7:25 AM
Harbormaster completed remote builds in B14799: Diff 20184.Dec 27 2022, 7:27 AM
ginsu requested review of this revision.Dec 27 2022, 7:27 AM
tomek accepted this revision.Dec 29 2022, 5:05 AM
atul resigned from this revision.Dec 29 2022, 12:48 PM

Resigning to unblock since this was reviewed by @tomek.

This revision is now accepted and ready to land.Dec 29 2022, 12:48 PM
Closed by commit rCOMM2c8502862fe5: [lib/native] move useCanCreateReactionFromMessage hook from native to lib (authored by ginsu). · Explain WhyDec 29 2022, 1:03 PM
This revision was automatically updated to reflect the committed changes.
ginsu added a commit: rCOMM2c8502862fe5: [lib/native] move useCanCreateReactionFromMessage hook from native to lib.

Revision Contents
Changeset List

Diff 20184

View Options

lib/shared/reaction-utils.js

Show All 11 Lines
CommunityStore::CommunityStore( CommunityStore::CommunityStore(
std::shared_ptr<facebook::react::CallInvoker> jsInvoker) std::shared_ptr<facebook::react::CallInvoker> jsInvoker)
: BaseDataStore(jsInvoker) { : BaseDataStore(jsInvoker) {
} }
jsi::Array CommunityStore::parseDBDataStore( jsi::Array CommunityStore::parseDBDataStore(
jsi::Runtime &rt, jsi::Runtime &rt,
std::shared_ptr<std::vector<CommunityInfo>> communitiesVectorPtr) const { std::shared_ptr<std::vector<CommunityInfo>> communitiesVectorPtr) const {
jsi::Array jsiCommunities = jsi::Array(rt, 0); size_t numCommunities = communitiesVectorPtr->size();
jsi::Array jsiCommunities = jsi::Array(rt, numCommunities);
size_t writeIdx = 0;
for (const CommunityInfo &community : *communitiesVectorPtr) {
jsi::Object jsiCommunity = jsi::Object(rt);
jsiCommunity.setProperty(rt, "id", community.id);
jsiCommunity.setProperty(rt, "communityInfo", community.community_info);
jsiCommunities.setValueAtIndex(rt, writeIdx++, jsiCommunity);
}
return jsiCommunities; return jsiCommunities;
} }
std::vector<std::unique_ptr<CommunityStoreOperationBase>> std::vector<std::unique_ptr<CommunityStoreOperationBase>>
CommunityStore::createOperations(jsi::Runtime &rt, const jsi::Array &operations) CommunityStore::createOperations(jsi::Runtime &rt, const jsi::Array &operations)
const { const {
std::vector<std::unique_ptr<CommunityStoreOperationBase>> communityStoreOps; std::vector<std::unique_ptr<CommunityStoreOperationBase>> communityStoreOps;
Show All 39 Lines
View Options

native/chat/multimedia-message.react.js

Show All 11 Lines
CommunityStore::CommunityStore( CommunityStore::CommunityStore(
std::shared_ptr<facebook::react::CallInvoker> jsInvoker) std::shared_ptr<facebook::react::CallInvoker> jsInvoker)
: BaseDataStore(jsInvoker) { : BaseDataStore(jsInvoker) {
} }
jsi::Array CommunityStore::parseDBDataStore( jsi::Array CommunityStore::parseDBDataStore(
jsi::Runtime &rt, jsi::Runtime &rt,
std::shared_ptr<std::vector<CommunityInfo>> communitiesVectorPtr) const { std::shared_ptr<std::vector<CommunityInfo>> communitiesVectorPtr) const {
jsi::Array jsiCommunities = jsi::Array(rt, 0); size_t numCommunities = communitiesVectorPtr->size();
jsi::Array jsiCommunities = jsi::Array(rt, numCommunities);
size_t writeIdx = 0;
for (const CommunityInfo &community : *communitiesVectorPtr) {
jsi::Object jsiCommunity = jsi::Object(rt);
jsiCommunity.setProperty(rt, "id", community.id);
jsiCommunity.setProperty(rt, "communityInfo", community.community_info);
jsiCommunities.setValueAtIndex(rt, writeIdx++, jsiCommunity);
}
return jsiCommunities; return jsiCommunities;
} }
std::vector<std::unique_ptr<CommunityStoreOperationBase>> std::vector<std::unique_ptr<CommunityStoreOperationBase>>
CommunityStore::createOperations(jsi::Runtime &rt, const jsi::Array &operations) CommunityStore::createOperations(jsi::Runtime &rt, const jsi::Array &operations)
const { const {
std::vector<std::unique_ptr<CommunityStoreOperationBase>> communityStoreOps; std::vector<std::unique_ptr<CommunityStoreOperationBase>> communityStoreOps;
Show All 39 Lines
View Options

native/chat/reaction-message-utils.js

Show All 11 Lines
CommunityStore::CommunityStore( CommunityStore::CommunityStore(
std::shared_ptr<facebook::react::CallInvoker> jsInvoker) std::shared_ptr<facebook::react::CallInvoker> jsInvoker)
: BaseDataStore(jsInvoker) { : BaseDataStore(jsInvoker) {
} }
jsi::Array CommunityStore::parseDBDataStore( jsi::Array CommunityStore::parseDBDataStore(
jsi::Runtime &rt, jsi::Runtime &rt,
std::shared_ptr<std::vector<CommunityInfo>> communitiesVectorPtr) const { std::shared_ptr<std::vector<CommunityInfo>> communitiesVectorPtr) const {
jsi::Array jsiCommunities = jsi::Array(rt, 0); size_t numCommunities = communitiesVectorPtr->size();
jsi::Array jsiCommunities = jsi::Array(rt, numCommunities);
size_t writeIdx = 0;
for (const CommunityInfo &community : *communitiesVectorPtr) {
jsi::Object jsiCommunity = jsi::Object(rt);
jsiCommunity.setProperty(rt, "id", community.id);
jsiCommunity.setProperty(rt, "communityInfo", community.community_info);
jsiCommunities.setValueAtIndex(rt, writeIdx++, jsiCommunity);
}
return jsiCommunities; return jsiCommunities;
} }
std::vector<std::unique_ptr<CommunityStoreOperationBase>> std::vector<std::unique_ptr<CommunityStoreOperationBase>>
CommunityStore::createOperations(jsi::Runtime &rt, const jsi::Array &operations) CommunityStore::createOperations(jsi::Runtime &rt, const jsi::Array &operations)
const { const {
std::vector<std::unique_ptr<CommunityStoreOperationBase>> communityStoreOps; std::vector<std::unique_ptr<CommunityStoreOperationBase>> communityStoreOps;
Show All 39 Lines
View Options

native/chat/robotext-message.react.js

Show All 11 Lines
CommunityStore::CommunityStore( CommunityStore::CommunityStore(
std::shared_ptr<facebook::react::CallInvoker> jsInvoker) std::shared_ptr<facebook::react::CallInvoker> jsInvoker)
: BaseDataStore(jsInvoker) { : BaseDataStore(jsInvoker) {
} }
jsi::Array CommunityStore::parseDBDataStore( jsi::Array CommunityStore::parseDBDataStore(
jsi::Runtime &rt, jsi::Runtime &rt,
std::shared_ptr<std::vector<CommunityInfo>> communitiesVectorPtr) const { std::shared_ptr<std::vector<CommunityInfo>> communitiesVectorPtr) const {
jsi::Array jsiCommunities = jsi::Array(rt, 0); size_t numCommunities = communitiesVectorPtr->size();
jsi::Array jsiCommunities = jsi::Array(rt, numCommunities);
size_t writeIdx = 0;
for (const CommunityInfo &community : *communitiesVectorPtr) {
jsi::Object jsiCommunity = jsi::Object(rt);
jsiCommunity.setProperty(rt, "id", community.id);
jsiCommunity.setProperty(rt, "communityInfo", community.community_info);
jsiCommunities.setValueAtIndex(rt, writeIdx++, jsiCommunity);
}
return jsiCommunities; return jsiCommunities;
} }
std::vector<std::unique_ptr<CommunityStoreOperationBase>> std::vector<std::unique_ptr<CommunityStoreOperationBase>>
CommunityStore::createOperations(jsi::Runtime &rt, const jsi::Array &operations) CommunityStore::createOperations(jsi::Runtime &rt, const jsi::Array &operations)
const { const {
std::vector<std::unique_ptr<CommunityStoreOperationBase>> communityStoreOps; std::vector<std::unique_ptr<CommunityStoreOperationBase>> communityStoreOps;
Show All 39 Lines
View Options

native/chat/text-message.react.js

Loading...