Page MenuHomePhabricator
Differential D6099

UI changes on native to allow account deletion for SIWE accounts
ClosedPublic
Actions

Authored by marcin on Dec 29 2022, 4:49 AM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Nov 8, 9:51 AM
Unknown Object (File)
Fri, Nov 8, 9:51 AM
Unknown Object (File)
Tue, Nov 5, 1:40 AM
Unknown Object (File)
Tue, Nov 5, 1:39 AM
Unknown Object (File)
Sun, Oct 27, 9:48 PM
Unknown Object (File)
Sun, Oct 27, 9:48 PM
Unknown Object (File)
Sun, Oct 27, 9:48 PM
Unknown Object (File)
Sun, Oct 27, 9:48 PM
View All Files
Subscribers
ashoat

Details

Reviewers
tomek
atul
Commits
rCOMM16f1362539a7: UI changes on native to allow account deletion for SIWE accounts
Summary

This differential adjusts account deletion panel on native to allow account deletion for SIWE accounts and still require non-empty password to delete conventional account.

Test Plan

For conventional account - ensure deletion process is not altered. For SIWE accounts - go to account deleter panel and ensure there is no password input prompt and just clicking on DELETE button succesfully deletes account.

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

marcin created this revision.Dec 29 2022, 4:49 AM
Herald added a subscriber: ashoat. · View Herald TranscriptDec 29 2022, 4:49 AM
marcin added a parent revision: D6098: Implement logic to skip password validation when account does not have one.Dec 29 2022, 4:49 AM
Harbormaster returned this revision to the author for changes because remote builds failed.Dec 29 2022, 4:53 AM
Harbormaster failed remote builds in B14917: Diff 20334!
marcin requested review of this revision.Dec 29 2022, 5:59 AM
tomek accepted this revision.Dec 29 2022, 6:41 AM
This revision is now accepted and ready to land.Dec 29 2022, 6:41 AM
tomek added inline comments.Dec 29 2022, 6:44 AM
native/profile/delete-account.react.js
257 ↗(On Diff #20334)

We can consider checking if account has password here

tomek added a comment.Dec 29 2022, 6:45 AM

Could you share a screenshot of the component without the password prompt?

marcin added a child revision: D6101: Soften requirements for password when deleting thread.Dec 29 2022, 6:47 AM
marcin added a comment.Dec 29 2022, 7:07 AM
In D6099#182857, @tomek wrote:

Could you share a screenshot of the component without the password prompt?

For SIWE account (does not prompt for password)

IMG_0002.PNG (2×1 px, 218 KB)

For conventional account
Zrzut ekranu 2022-12-29 o 16.05.29.png (2×1 px, 140 KB)

native/profile/delete-account.react.js
257 ↗(On Diff #20334)

You are right - it should simplify the code.

tomek added a comment.Dec 29 2022, 7:09 AM
In D6099#182910, @marcin wrote:
In D6099#182857, @tomek wrote:

Could you share a screenshot of the component without the password prompt?

For SIWE account (does not prompt for password)

IMG_0002.PNG (2×1 px, 218 KB)

For conventional account
Zrzut ekranu 2022-12-29 o 16.05.29.png (2×1 px, 140 KB)

The images don't show for me. https://www.notion.so/commapp/Attaching-files-and-images-on-Phabricator-af8e2195fc91462689cc8de5c96a6759

marcin attached a referenced file: F310171: Zrzut ekranu 2022-12-29 o 16.05.29.png. (Show Details)Dec 29 2022, 7:10 AM
marcin attached a referenced file: F310167: IMG_0002.PNG. (Show Details)
marcin updated this revision to Diff 20343.Dec 29 2022, 7:59 AM

Use direct selector with accountHasPassword

Harbormaster failed remote builds in B14926: Diff 20343!Dec 29 2022, 8:03 AM
marcin updated this revision to Diff 20353.Dec 29 2022, 8:47 AM

Rebase master

Harbormaster completed remote builds in B14935: Diff 20353.Dec 29 2022, 9:01 AM
marcin updated this revision to Diff 20418.Dec 30 2022, 3:36 AM

Rebase before landing

Harbormaster completed remote builds in B14967: Diff 20418.Dec 30 2022, 3:50 AM
Closed by commit rCOMM16f1362539a7: UI changes on native to allow account deletion for SIWE accounts (authored by marcin). · Explain WhyDec 30 2022, 4:13 AM
This revision was automatically updated to reflect the committed changes.
marcin added a commit: rCOMM16f1362539a7: UI changes on native to allow account deletion for SIWE accounts.
atul mentioned this in D6349: [web] Allow account deletion for SIWE accounts.Jan 23 2023, 9:55 AM
atul mentioned this in rCOMMcb1fb3254d87: [web] Allow account deletion for SIWE accounts.Jan 24 2023, 9:53 AM

Revision Contents
Changeset List

PathSize
native/
profile/
55 lines

Diff 20418

View Options

native/profile/delete-account.react.js

Loading...