Details

Reviewers

tomek
atul

Commits

rCOMM16f1362539a7: UI changes on native to allow account deletion for SIWE accounts

Summary

This differential adjusts account deletion panel on native to allow account deletion for SIWE accounts and still require non-empty password to delete conventional account.

Test Plan

For conventional account - ensure deletion process is not altered. For SIWE accounts - go to account deleter panel and ensure there is no password input prompt and just clicking on DELETE button succesfully deletes account.

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

marcin created this revision.Dec 29 2022, 4:49 AM

Herald added a subscriber: ashoat. · View Herald TranscriptDec 29 2022, 4:49 AM

marcin added a parent revision: D6098: Implement logic to skip password validation when account does not have one.Dec 29 2022, 4:49 AM

Harbormaster returned this revision to the author for changes because remote builds failed.Dec 29 2022, 4:53 AM

Harbormaster failed remote builds in B14917: Diff 20334!

marcin requested review of this revision.Dec 29 2022, 5:59 AM

tomek accepted this revision.Dec 29 2022, 6:41 AM

This revision is now accepted and ready to land.Dec 29 2022, 6:41 AM

tomek added inline comments.Dec 29 2022, 6:44 AM

native/profile/delete-account.react.js
257 ↗	(On Diff #20334)	We can consider checking if account has password here

Could you share a screenshot of the component without the password prompt?

marcin added a child revision: D6101: Soften requirements for password when deleting thread.Dec 29 2022, 6:47 AM

In D6099#182857, @tomek wrote:

Could you share a screenshot of the component without the password prompt?

For SIWE account (does not prompt for password)

For conventional account

Zrzut ekranu 2022-12-29 o 16.05.29.png (2×1 px, 140 KB)

native/profile/delete-account.react.js
257 ↗	(On Diff #20334)	You are right - it should simplify the code.

In D6099#182910, @marcin wrote:

In D6099#182857, @tomek wrote:

Could you share a screenshot of the component without the password prompt?

For SIWE account (does not prompt for password)

For conventional account