Page MenuHomePhabricator

Remove react-native-notifications dependency from project
ClosedPublic

Authored by marcin on Jan 2 2023, 7:32 AM.
Tags
None
Referenced Files
F3491354: D6141.id20505.diff
Wed, Dec 18, 7:02 PM
F3490460: D6141.diff
Wed, Dec 18, 4:19 PM
Unknown Object (File)
Sat, Dec 14, 4:14 AM
Unknown Object (File)
Sat, Dec 14, 4:14 AM
Unknown Object (File)
Sat, Dec 14, 4:14 AM
Unknown Object (File)
Sat, Dec 14, 4:14 AM
Unknown Object (File)
Sat, Dec 14, 4:13 AM
Unknown Object (File)
Sat, Dec 14, 4:07 AM
Subscribers

Details

Summary

This differential removes react-native-notifications dependency from repo. changes in files were not created manually but by running: "yarn remove react-native-notifications" (in native directory) and then yarn cleaninstall (in project root).

Test Plan

Since all react-native-notifications are already removed and replaced, the only test plan we need is to successfully build the app

Diff Detail

Repository
rCOMM Comm
Branch
marcin/eng-2334
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

marcin requested review of this revision.Jan 2 2023, 7:47 AM

Exciting!!

native/react-native.config.js
6

Good work catching this

This revision is now accepted and ready to land.Jan 3 2023, 10:34 AM