Page MenuHomePhabricator

[image-picker] install expo-image-picker lib
ClosedPublic

Authored by adar on Jan 3 2023, 7:16 AM.
Tags
None
Referenced Files
F3247408: D6145.id20585.diff
Fri, Nov 15, 5:08 AM
F3247289: D6145.id20630.diff
Fri, Nov 15, 4:33 AM
F3247005: D6145.diff
Fri, Nov 15, 2:51 AM
F3245677: D6145.id.diff
Thu, Nov 14, 8:00 PM
Unknown Object (File)
Mon, Nov 4, 8:04 AM
Unknown Object (File)
Tue, Oct 29, 1:50 AM
Unknown Object (File)
Sun, Oct 20, 4:19 AM
Unknown Object (File)
Fri, Oct 18, 2:29 AM
Subscribers

Details

Summary

This diff installs the expo-image-picker library.

Test Plan

There are no callsites to this library yet, so we just want to make sure the build succeeds for iOS and Android and the app runs successfully.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

adar held this revision as a draft.
atul requested changes to this revision.Jan 3 2023, 11:44 AM

Can you git pull --rebase and then run yarn cleaninstall in root and pod install in native/ios?

I tried patching this in locally and at least yarn.lock didn't match (didn't try pod install because that takes forever)

This revision now requires changes to proceed.Jan 3 2023, 11:44 AM

FYI you'll need to add @ashoat as a reviewer for dependency diffs:

604f81.png (558×842 px, 97 KB)

yarn.lock
18944–18947 ↗(On Diff #20518)

This change is happening because you ran yarn add or yarn remove or something in a local workspace. It's a bug in Yarn unfortunately. Instead you should update your package.json manually and then run yarn cleaninstall in the root of the repo

manually updated package.json and ran yarn cleaninstall in root

yarn.lock
22770 ↗(On Diff #20585)

is this change to uuid normal? if so why?

ashoat added inline comments.
yarn.lock
22770 ↗(On Diff #20585)

Seems it is being introduced since it's a dependency of expo-image-picker

This revision is now accepted and ready to land.Jan 4 2023, 11:26 PM