Page MenuHomePhabricator
Differential D6226

Move CommNotificationsHandler to newly created notifications package
ClosedPublic
Actions

Authored by marcin on Jan 11 2023, 3:58 AM.
Tags
None
Referenced Files
F3487440: D6226.id20782.diff
Wed, Dec 18, 7:45 AM
F3487430: D6226.id21586.diff
Wed, Dec 18, 7:43 AM
F3487236: D6226.id21443.diff
Wed, Dec 18, 7:27 AM
F3487227: D6226.id21559.diff
Wed, Dec 18, 7:25 AM
F3486384: D6226.diff
Wed, Dec 18, 4:44 AM
Unknown Object (File)
Sat, Dec 14, 3:50 AM
Unknown Object (File)
Sat, Dec 14, 3:50 AM
Unknown Object (File)
Sat, Dec 14, 3:50 AM
View All Files
Subscribers
ashoat

Details

Reviewers
tomek
atul
ashoat
Commits
rCOMM417368004d63: Move CommNotificationsHandler to newly created notifications package
Summary

This differential creates specialized package for code intended to deal with notifications and places CommNotificationsHandler there. Future differentials will add more files to this package

Test Plan

This differential brings no functional change. Build the app and ensure that notification displaying (foreground and background) as well as rescinding works the same.

Diff Detail

Repository
rCOMM Comm
Branch
marcin/eng-2501
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

marcin created this revision.Jan 11 2023, 3:58 AM
Herald added a subscriber: ashoat. · View Herald TranscriptJan 11 2023, 3:58 AM
marcin added a child revision: D6227: Implement native Android module that can remove all active notifications for a given thread.Jan 11 2023, 4:08 AM
Harbormaster completed remote builds in B15242: Diff 20782.Jan 11 2023, 4:13 AM
marcin requested review of this revision.Jan 11 2023, 4:13 AM
ashoat added inline comments.Jan 11 2023, 8:43 AM
native/android/app/src/main/java/app/comm/android/notifications/CommNotificationsHandler.java
1

What's the benefit of this custom package?

tomek added inline comments.Jan 11 2023, 8:51 AM
native/android/app/src/main/java/app/comm/android/notifications/CommNotificationsHandler.java
1

It is a convention in Java to have 1:1 matching between packages and directories https://stackoverflow.com/questions/8395916/package-name-is-different-than-the-folder-structure-but-still-java-code-compiles/8395934#8395934

ashoat accepted this revision.Jan 11 2023, 8:55 AM

Okay

This revision is now accepted and ready to land.Jan 11 2023, 8:55 AM
marcin added inline comments.Jan 13 2023, 12:32 AM
native/android/app/src/main/java/app/comm/android/notifications/CommNotificationsHandler.java
1

I decided to move this file to separate directory since future differentials in this stack will introduce additional files to handle notifications functionality. I think keeping them in dedicated directory keeps code tidy and uncluttered.

tomek accepted this revision.Jan 18 2023, 6:44 AM
marcin updated this revision to Diff 21443.Jan 27 2023, 6:32 AM

Rebase before landing

Harbormaster completed remote builds in B15722: Diff 21443.Jan 27 2023, 6:46 AM
marcin updated this revision to Diff 21559.Jan 30 2023, 3:05 AM

Rebase before landing

Harbormaster completed remote builds in B15813: Diff 21559.Jan 30 2023, 3:19 AM
Closed by commit rCOMM417368004d63: Move CommNotificationsHandler to newly created notifications package (authored by marcin). · Explain WhyJan 30 2023, 4:12 AM
This revision was automatically updated to reflect the committed changes.
marcin added a commit: rCOMM417368004d63: Move CommNotificationsHandler to newly created notifications package.

Revision Contents
Changeset List

PathSize
native/
android/
app/
src/
main/
2 lines
java/
app/
comm/
android/
notifications/
3 lines

Diff 20782

View Options

native/android/app/src/main/AndroidManifest.xml

Loading...
View Options

native/android/app/src/main/java/app/comm/android/CommNotificationsHandler.java

Loading...
View Options

native/android/app/src/main/java/app/comm/android/notifications/CommNotificationsHandler.java

Loading...