Page MenuHomePhabricator
Differential D6217

[web] Introduce `LoginFormWrapper` component
ClosedPublic
Actions

Authored by atul on Jan 10 2023, 1:28 PM.
Tags
None
Referenced Files
F2906943: D6217.id20814.diff
Sun, Oct 6, 10:21 AM
F2905833: D6217.diff
Sun, Oct 6, 8:24 AM
Unknown Object (File)
Thu, Sep 26, 11:13 PM
Unknown Object (File)
Thu, Sep 26, 11:13 PM
Unknown Object (File)
Thu, Sep 26, 11:13 PM
Unknown Object (File)
Thu, Sep 26, 11:13 PM
Unknown Object (File)
Thu, Sep 26, 11:10 PM
Unknown Object (File)
Wed, Sep 18, 4:13 PM
View All Files
Subscribers
None

Details

Reviewers
ashoat
tomek
Commits
rCOMMee86b784e398: [web] Introduce `LoginFormWrapper` component
Summary

Basically wrap LoginForm with RainbowKitProvider and WagmiConfig.

Inspired heavily by (read: copied from) landing/siwe.react.js.

Test Plan

Tested implicitly by subsequent diffs.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

atul created this revision.Jan 10 2023, 1:28 PM
atul published this revision for review.Jan 10 2023, 1:33 PM
Harbormaster completed remote builds in B15229: Diff 20759.Jan 10 2023, 1:43 PM
atul added a child revision: D6218: [web] Add `siweButton` to `LogInForm` component.Jan 10 2023, 2:29 PM
ashoat accepted this revision.Jan 10 2023, 7:13 PM
ashoat added inline comments.
web/account/log-in-form.react.js
3 ↗(On Diff #20759)

Note that this means we're including this CSS in literally every pageload of web. It's gonna bloat the bundle, which is pretty unavoidable... hopefully it doesn't have any global styles

205 ↗(On Diff #20759)

Where did we get this color again? It only seems to be used in the SIWE code, not sure if this is me or Derek or what but just wondering what the history is

This revision is now accepted and ready to land.Jan 10 2023, 7:13 PM
atul added inline comments.Jan 11 2023, 1:28 PM
web/account/log-in-form.react.js
3 ↗(On Diff #20759)

Did a quick skim and looks like every CSS selector in dist/index.css starts with [data-rk] and something unique like .iekbcc1

205 ↗(On Diff #20759)

Was introduced by you in D6003, not sure on the exact origin.

atul updated this revision to Diff 20813.Jan 11 2023, 1:28 PM

rebase before landing

This revision was landed with ongoing or failed builds.Jan 11 2023, 1:29 PM
Closed by commit rCOMMee86b784e398: [web] Introduce `LoginFormWrapper` component (authored by atul). · Explain Why
This revision was automatically updated to reflect the committed changes.
atul added a commit: rCOMMee86b784e398: [web] Introduce `LoginFormWrapper` component.
Harbormaster completed remote builds in B15263: Diff 20813.Jan 11 2023, 1:43 PM

Revision Contents
Changeset List

PathSize
web/
account/
54 lines

Diff 20814

View Options

web/account/log-in-form.react.js

Loading...