Page MenuHomePhabricator
Differential D6254

[keyserver] call identity service register RPC on account creation
AbandonedPublic
Actions

Authored by varun on Jan 12 2023, 8:57 AM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Nov 8, 10:03 AM
Unknown Object (File)
Fri, Nov 8, 10:03 AM
Unknown Object (File)
Fri, Nov 8, 10:03 AM
Unknown Object (File)
Fri, Nov 8, 10:03 AM
Unknown Object (File)
Fri, Nov 8, 10:03 AM
Unknown Object (File)
Sun, Oct 27, 5:42 PM
Unknown Object (File)
Mon, Oct 21, 5:21 AM
Unknown Object (File)
Sun, Oct 20, 10:30 PM
View All Files
Subscribers
ashoat
atul
• max

Details

Reviewers
tomek
ashoat
Summary

when an account is successfully created locally, we should send the account info to the identity service via the register RPC

Depends on D5796

Test Plan

successfully added new user info to identity service when registering a new account on keyserver

Diff Detail

Repository
rCOMM Comm
Branch
master
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

varun created this revision.Jan 12 2023, 8:57 AM
Herald added subscribers: atul, ashoat. · View Herald TranscriptJan 12 2023, 8:57 AM
Harbormaster returned this revision to the author for changes because remote builds failed.Jan 12 2023, 9:00 AM
Harbormaster failed remote builds in B15302: Diff 20877!
varun updated this revision to Diff 20906.Jan 12 2023, 2:44 PM

rebase

Harbormaster returned this revision to the author for changes because remote builds failed.Jan 12 2023, 2:46 PM
Harbormaster failed remote builds in B15329: Diff 20906!
varun updated this revision to Diff 20953.Jan 13 2023, 12:09 PM

rebase

Harbormaster completed remote builds in B15363: Diff 20953.Jan 13 2023, 12:24 PM
varun requested review of this revision.Jan 13 2023, 12:24 PM
tomek requested changes to this revision.Jan 17 2023, 8:44 AM
tomek added inline comments.
keyserver/src/creators/account-creator.js
199–209 ↗(On Diff #20953)

Are we able to successfully register the account using placeholders? I guess these are needed when older clients try to register, but what would be the result of calling this function with these values?

This revision now requires changes to proceed.Jan 17 2023, 8:44 AM
ashoat requested changes to this revision.Jan 19 2023, 11:43 AM

You need to update registerRequestInputValidator

keyserver/src/creators/account-creator.js
200 ↗(On Diff #20953)

I think this should be a devicePublicKey

lib/types/account-types.js
55 ↗(On Diff #20953)

I think this should be a devicePublicKey, and we need to test setting these

ashoat added inline comments.Jan 19 2023, 1:55 PM
keyserver/src/creators/account-creator.js
199 ↗(On Diff #20953)

I don't think we need a concept of a deviceID separate from the devicePublicKey

varun abandoned this revision.Mar 3 2023, 3:05 PM

Revision Contents
Changeset List

PathSize
keyserver/
src/
creators/
16 lines
lib/
types/
2 lines

Diff 20906

View Options

keyserver/src/creators/account-creator.js

Loading...
View Options

lib/types/account-types.js

Loading...