Page MenuHomePhabricator
Differential D6209

Add parent name to subchannels and sidebars modals
ClosedPublic
Actions

Authored by inka on Jan 10 2023, 12:23 AM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Oct 29, 7:47 PM
Unknown Object (File)
Tue, Oct 29, 5:24 PM
Unknown Object (File)
Tue, Oct 29, 5:24 PM
Unknown Object (File)
Tue, Oct 29, 5:24 PM
Unknown Object (File)
Tue, Oct 29, 5:24 PM
Unknown Object (File)
Tue, Oct 29, 5:24 PM
Unknown Object (File)
Tue, Oct 29, 5:21 PM
Unknown Object (File)
Sep 30 2024, 10:20 AM
View All Files
Subscribers
ashoat
atul
tomek

Details

Reviewers
• przemek
bartek
tomek
Commits
rCOMM2b9eb4321018: Add parent name to subchannels and sidebars modals
Summary

Issue: https://linear.app/comm/issue/ENG-2547/restyle-sidebarlistmodal-and-subchannelslistmodal
Desing issue: https://linear.app/comm/issue/DES-20/designs-for-subchannels-modal
Adding parent name pill in the modals header

Screenshot 2023-01-09 at 17.34.30.png (1×554 px, 182 KB)

Screenshot 2023-01-09 at 17.34.17.png (1×550 px, 161 KB)

Screenshot 2023-01-10 at 09.19.44.png (1×580 px, 178 KB)

Test Plan

Run ios simulator, check that name displays correctly for short na long names in both subchannels modal and in sidebars modal

Diff Detail

Repository
rCOMM Comm
Branch
inka/native_modals
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

inka created this revision.Jan 10 2023, 12:23 AM
Herald added subscribers: atul, tomek, ashoat. · View Herald TranscriptJan 10 2023, 12:23 AM
inka edited the summary of this revision. (Show Details)Jan 10 2023, 12:24 AM
inka edited the test plan for this revision. (Show Details)
inka attached a referenced file: F324566: Screenshot 2023-01-10 at 09.19.44.png. (Show Details)
inka attached a referenced file: F324564: Screenshot 2023-01-09 at 17.34.17.png. (Show Details)
inka attached a referenced file: F324565: Screenshot 2023-01-09 at 17.34.30.png. (Show Details)
Harbormaster completed remote builds in B15218: Diff 20748.Jan 10 2023, 12:37 AM
inka requested review of this revision.Jan 10 2023, 12:37 AM
bartek accepted this revision.Jan 10 2023, 3:09 AM

Looks neat

This revision is now accepted and ready to land.Jan 10 2023, 3:09 AM
inka added a reviewer: tomek.Jan 11 2023, 12:47 AM
This revision now requires review to proceed.Jan 11 2023, 12:47 AM
tomek accepted this revision.Jan 11 2023, 2:55 AM
tomek added inline comments.
native/chat/thread-list-modal.react.js
115–139 ↗(On Diff #20748)

Is there a reason for creating parentChat separately?

165 ↗(On Diff #20748)

We probably should use something thinner.

This revision is now accepted and ready to land.Jan 11 2023, 2:55 AM
tomek requested changes to this revision.Jan 11 2023, 8:27 AM
tomek added inline comments.
native/chat/thread-list-modal.react.js
115–121 ↗(On Diff #20748)

Maybe we can use Pill / ThreadPill components?

This revision now requires changes to proceed.Jan 11 2023, 8:27 AM
inka updated this revision to Diff 20929.Jan 13 2023, 5:18 AM

Use ThreadPill component

Harbormaster failed remote builds in B15349: Diff 20929!Jan 13 2023, 5:20 AM
tomek accepted this revision.Jan 13 2023, 7:29 AM
tomek added inline comments.
native/themes/colors.js
191

Do we use this value?

This revision is now accepted and ready to land.Jan 13 2023, 7:29 AM
inka updated this revision to Diff 20968.Jan 16 2023, 12:36 AM

Remove unused colour

Harbormaster failed remote builds in B15377: Diff 20968!Jan 16 2023, 12:48 AM
Harbormaster completed remote builds in B15377: Diff 20968.Jan 17 2023, 4:57 AM
Closed by commit rCOMM2b9eb4321018: Add parent name to subchannels and sidebars modals (authored by • InkaSokolowska). · Explain WhyJan 19 2023, 1:14 AM
This revision was automatically updated to reflect the committed changes.
• InkaSokolowska added a commit: rCOMM2b9eb4321018: Add parent name to subchannels and sidebars modals.

Revision Contents
Changeset List

PathSize
native/
chat/
41 lines
themes/
2 lines

Diff 20929

View Options

native/chat/thread-list-modal.react.js

Loading...
View Options

native/themes/colors.js

Loading...