Page MenuHomePhabricator
Differential D6285

[Nix] Add awscli2 to dev shell
ClosedPublic
Actions

Authored by • jon on Jan 17 2023, 7:11 AM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Dec 17, 6:49 AM
Unknown Object (File)
Tue, Dec 17, 6:49 AM
Unknown Object (File)
Tue, Dec 17, 6:49 AM
Unknown Object (File)
Tue, Dec 17, 6:48 AM
Unknown Object (File)
Tue, Dec 17, 6:46 AM
Unknown Object (File)
Tue, Dec 3, 1:40 AM
Unknown Object (File)
Nov 14 2024, 4:43 PM
Unknown Object (File)
Nov 14 2024, 4:43 PM
View All Files
Subscribers
ashoat
atul
tomek

Details

Reviewers
• max
bartek
varun
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Commits
rCOMMfab8b86c0363: [Nix] Add awscli2 to dev shell
Summary

Some services workflows may require
aws to create some cloud resources.

Part of https://linear.app/comm/issue/ENG-2649

Test Plan
nix develop
which aws # should come to Nix store

Testing this thoroughly would include a workflow
which involves being setup with aws.

Diff Detail

Repository
rCOMM Comm
Branch
jonringer/add-awscli
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

• jon created this revision.Jan 17 2023, 7:11 AM
Owners added a reviewer: Restricted Owners Package.Jan 17 2023, 7:11 AM
Herald added subscribers: atul, tomek, ashoat. · View Herald TranscriptJan 17 2023, 7:11 AM
Harbormaster returned this revision to the author for changes because remote builds failed.Jan 17 2023, 7:13 AM
Harbormaster failed remote builds in B15404: Diff 21006!
• jon requested review of this revision.Jan 17 2023, 8:19 AM

Android failure should be solved by https://phab.comm.dev/D6288

bartek accepted this revision.Jan 17 2023, 8:31 AM

Patched this and can confirm it works for me, thanks!

As I mentioned in ENG-2649, I'm using the Nix version of awscli2 already (nix shell nixpkgs#awscli2) and had no issues so far.

# how I tested
nix develop && cd services
yarn init-local-cloud
aws --endpoint-url=http://localhost:4566 dynamodb list-tables
# should display list of our tables
• jon updated this revision to Diff 21030.Jan 17 2023, 1:10 PM

Rebase on android gate fixes

Harbormaster completed remote builds in B15422: Diff 21030.Jan 17 2023, 1:24 PM
• jon added a reviewer: varun.Jan 19 2023, 11:01 AM
varun accepted this revision.Jan 19 2023, 11:20 AM
This revision is now accepted and ready to land.Jan 19 2023, 11:20 AM
Closed by commit rCOMMfab8b86c0363: [Nix] Add awscli2 to dev shell (authored by • jon). · Explain WhyJan 19 2023, 11:33 AM
This revision was automatically updated to reflect the committed changes.
• jon added a commit: rCOMMfab8b86c0363: [Nix] Add awscli2 to dev shell.

Revision Contents
Changeset List

PathSize
nix/
2 lines

Diff 21030

View Options

nix/dev-shell.nix

Loading...