Page MenuHomePhabricator

[native] Add presentation: 'transparentModal' to termsAndPrivacyModalScreenOptions
ClosedPublic

Authored by ashoat on Jan 21 2023, 1:00 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Feb 13, 2:45 AM
Unknown Object (File)
Thu, Feb 13, 2:45 AM
Unknown Object (File)
Thu, Feb 13, 2:44 AM
Unknown Object (File)
Thu, Feb 13, 2:37 AM
Unknown Object (File)
Feb 2 2025, 4:39 PM
Unknown Object (File)
Feb 2 2025, 4:48 AM
Unknown Object (File)
Jan 27 2025, 10:15 AM
Unknown Object (File)
Jan 27 2025, 10:15 AM
Subscribers

Details

Summary

I should've covered this in D5891. Without this, I think the screen behind the modal won't appear on Android.

Test Plan

I haven't had a chance to test this, but my theory is that without this, the Terms & Privacy modal appears on Android with the background completely black. @kamil, have you seen this on Android?

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

kamil added inline comments.
native/navigation/root-navigator.react.js
162

I haven't had a chance to test this, but my theory is that without this, the Terms & Privacy modal appears on Android with the background completely black. @kamil, have you seen this on Android?

I've seen it, but I thought it was supposed to look like this because I compared it to other app modals

I tested this for you
Before:

image.png (961×918 px, 515 KB)

After:

image.png (925×934 px, 505 KB)

This revision is now accepted and ready to land.Jan 23 2023, 7:03 AM

FYI I can't see those screenshots because of this issue, but I assume you're showing that the change was positive since you accepted the diff, so I'll go ahead and land