Adds the electron update server to the services. It's using the hazel package.
Details
Details
Run yarn dev and yarn prod (with env vars pointing at a custom repo) and check if it correctly serves files. Example:
HAZEL_ACCOUNT=MichalGniadek HAZEL_REPOSITORY=comm-test-gh HAZEL_PORT=3005 yarn dev will use this repo: https://github.com/MichalGniadek/comm-test-gh that already has some releases with necessary files created.
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Lint
No Lint Coverage - Unit
No Test Coverage
Event Timeline
Comment Actions
- We should update the root package.json to introduce the new workspace
- Once we do that, we probably will need to patch keyserver/Dockerfile to reflect the new workspace
| services/electron-update-server/index.cjs | ||
|---|---|---|
| 1 | Why can't this be ESM + Flow? | |
| services/electron-update-server/.flowconfig | ||
|---|---|---|
| 2 ↗ | (On Diff #21259) | For the express typings. |
| services/electron-update-server/flow-typed/npm/hazel-server_vx.x.x.js | ||
| 6 ↗ | (On Diff #21259) | There are no typescript types available or existing flow-type typings. I took the options from here, and checked if the types make sense in the rest of the hazel code. |
Comment Actions
Run yarn dev and yarn prod (with env vars pointing at a custom repo) and check if it correctly serves files.
Could you expand Test Plan a bit? Specifically, what environment variables need to be set + what's a good example repo to test against.
Comment Actions
Awesome!!
Just one inline comment and a question: should we be calling flow from lint-staged too? (Maybe needs to be added for desktop as well)
| services/electron-update-server/.flowconfig | ||
|---|---|---|
| 2 ↗ | (On Diff #21259) | We use express directly in electron-update-server, so I think it would be better to flow-typed install express in electron-update-server |
Comment Actions
Updated the test plan, added flow to lint-staged (desktop is already added, I just forgot about this file), added flow typed for express to electron-update-server instead on relying on types in keyserver.