Page MenuHomePhabricator
Differential D6378

Implement native method to update badge count and use it in JavaScript
ClosedPublic
Actions

Authored by marcin on Jan 25 2023, 12:57 AM.
Tags
None
Referenced Files
F3252707: D6378.diff
Fri, Nov 15, 6:32 PM
Unknown Object (File)
Fri, Nov 8, 6:50 PM
Unknown Object (File)
Fri, Nov 8, 3:02 AM
Unknown Object (File)
Fri, Nov 8, 3:02 AM
Unknown Object (File)
Fri, Nov 8, 3:02 AM
Unknown Object (File)
Fri, Nov 8, 3:02 AM
Unknown Object (File)
Fri, Nov 8, 3:02 AM
Unknown Object (File)
Fri, Nov 8, 3:02 AM
View All Files
Subscribers
ashoat
atul

Details

Reviewers
tomek
bartek
Commits
rCOMM86baed3f849a: Implement native method to update badge count and use it in JavaScript
Summary

This differential implements native method to update application badge count and uses it in JavaScript. Relevant types are adjusted as well.

Test Plan

Build the app. Send several messages, open the app but do not read messages. Close the app and ensure that there is unread badge on app icon. Open the app, read messages and close the app.
Ensure that badge disappears from app icon.

Diff Detail

Repository
rCOMM Comm
Branch
marcin/eng-2501
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

marcin created this revision.Jan 25 2023, 12:57 AM
Herald added subscribers: atul, ashoat. · View Herald TranscriptJan 25 2023, 12:57 AM
marcin added a parent revision: D6377: Implement native method to create notification channel.Jan 25 2023, 12:57 AM
marcin added a child revision: D6379: Implement native method to remove all active notifications and use it in JavaScript.Jan 25 2023, 1:07 AM
Harbormaster completed remote builds in B15617: Diff 21291.Jan 25 2023, 1:11 AM
marcin requested review of this revision.Jan 25 2023, 1:11 AM
tomek accepted this revision.Jan 26 2023, 2:49 AM
This revision is now accepted and ready to land.Jan 26 2023, 2:49 AM
bartek accepted this revision.Jan 26 2023, 4:48 AM
marcin updated this revision to Diff 21457.Jan 27 2023, 6:42 AM

Rebase before landing

Harbormaster completed remote builds in B15736: Diff 21457.Jan 27 2023, 6:58 AM
marcin updated this revision to Diff 21573.Jan 30 2023, 3:12 AM

Rebase before landing

Harbormaster completed remote builds in B15827: Diff 21573.Jan 30 2023, 3:30 AM
Closed by commit rCOMM86baed3f849a: Implement native method to update badge count and use it in JavaScript (authored by marcin). · Explain WhyJan 30 2023, 4:12 AM
This revision was automatically updated to reflect the committed changes.
marcin added a commit: rCOMM86baed3f849a: Implement native method to update badge count and use it in JavaScript.

Revision Contents
Changeset List

PathSize
native/
android/
app/
src/
main/
java/
app/
comm/
android/
notifications/
10 lines
push/
1 line
2 lines

Diff 21291

View Options

native/android/app/src/main/java/app/comm/android/notifications/CommAndroidNotifications.java

Loading...
View Options

native/push/android.js

Loading...
View Options

native/push/push-handler.react.js

Loading...