Page MenuHomePhabricator
Differential D6379

Implement native method to remove all active notifications and use it in JavaScript
ClosedPublic
Actions

Authored by marcin on Jan 25 2023, 1:07 AM.
Tags
None
Referenced Files
F3492592: D6379.id21292.diff
Thu, Dec 19, 12:44 AM
F3488157: D6379.id21601.diff
Wed, Dec 18, 9:13 AM
F3488042: D6379.id21458.diff
Wed, Dec 18, 8:49 AM
F3487519: D6379.id21574.diff
Wed, Dec 18, 8:22 AM
Unknown Object (File)
Wed, Dec 18, 6:03 AM
Unknown Object (File)
Nov 8 2024, 3:03 AM
Unknown Object (File)
Nov 8 2024, 3:03 AM
Unknown Object (File)
Nov 8 2024, 3:03 AM
View All Files
Subscribers
ashoat
atul

Details

Reviewers
tomek
bartek
Commits
rCOMMe5933f8afe5d: Implement native method to remove all active notifications and use it in…
Summary

This differential implements native method to remove all active notifications and uses it in JavaScript. RElevant types are updated as well.

Test Plan

Build the app. CLose it. Send several messages. Open the app, but do not read messages (so that notifications are still in notification center). Log out. Ensure notifications are removed from
notification center.

Diff Detail

Repository
rCOMM Comm
Branch
marcin/eng-2501
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

marcin created this revision.Jan 25 2023, 1:07 AM
Herald added subscribers: atul, ashoat. · View Herald TranscriptJan 25 2023, 1:07 AM
marcin added a parent revision: D6378: Implement native method to update badge count and use it in JavaScript.Jan 25 2023, 1:07 AM
Harbormaster returned this revision to the author for changes because remote builds failed.Jan 25 2023, 1:19 AM
Harbormaster failed remote builds in B15618: Diff 21292!
Harbormaster completed remote builds in B15618: Diff 21292.Jan 25 2023, 1:36 AM
marcin requested review of this revision.Jan 25 2023, 1:36 AM
marcin added a child revision: D6380: Implement native method to check for notifications permissions and use it in JavaScript.Jan 25 2023, 1:46 AM
tomek accepted this revision.Jan 26 2023, 2:54 AM
This revision is now accepted and ready to land.Jan 26 2023, 2:54 AM
bartek accepted this revision.Jan 26 2023, 4:49 AM
marcin updated this revision to Diff 21458.Jan 27 2023, 6:42 AM

Rebase before landing

Harbormaster completed remote builds in B15737: Diff 21458.Jan 27 2023, 7:00 AM
marcin updated this revision to Diff 21574.Jan 30 2023, 3:12 AM

Rebase before landing

Harbormaster completed remote builds in B15828: Diff 21574.Jan 30 2023, 3:33 AM
Closed by commit rCOMMe5933f8afe5d: Implement native method to remove all active notifications and use it in… (authored by marcin). · Explain WhyJan 30 2023, 4:12 AM
This revision was automatically updated to reflect the committed changes.
marcin added a commit: rCOMMe5933f8afe5d: Implement native method to remove all active notifications and use it in….

Revision Contents
Changeset List

PathSize
native/
android/
app/
src/
main/
java/
app/
comm/
android/
notifications/
5 lines
push/
1 line
2 lines

Diff 21292

View Options

native/android/app/src/main/java/app/comm/android/notifications/CommAndroidNotifications.java

Loading...
View Options

native/push/android.js

Loading...
View Options

native/push/push-handler.react.js

Loading...