Page MenuHomePhabricator
Differential D6405

[yarn] Run `yarn-deduplicate` to tidy up `yarn.lock`
AbandonedPublic
Actions

Authored by atul on Jan 26 2023, 1:50 PM.
Tags
None
Referenced Files
F2209589: D6405.id21501.diff
Sun, Jul 7, 6:00 PM
F2209584: D6405.id21502.diff
Sun, Jul 7, 5:57 PM
F2209493: D6405.id21513.diff
Sun, Jul 7, 5:29 PM
F2209347: D6405.id21396.diff
Sun, Jul 7, 4:55 PM
Unknown Object (File)
Sat, Jul 6, 4:17 AM
Unknown Object (File)
Fri, Jul 5, 10:25 PM
Unknown Object (File)
Fri, Jul 5, 11:08 AM
Unknown Object (File)
Thu, Jul 4, 9:51 PM
View All 45 Files
Subscribers
ashoat

Details

Reviewers
tomek
marcin
• jon
bartek
ashoat
Commits
rCOMMc0eeb2d6759c: [yarn] Run `yarn-deduplicate` to tidy up `yarn.lock`
Summary

Noticed that yarn cleaninstall was taking a while for me (~120 seconds). Back down to ~100 seconds after running yarn-deduplicate. Didn't do any in-depth profiling, so improvement might just be random noise.. but figured it wouldn't hurt.

Test Plan

Trusting semver and CI. Happy to just abandon this if there's any concern.

Diff Detail

Repository
rCOMM Comm
Branch
master
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

atul created this revision.Jan 26 2023, 1:50 PM
Herald added a subscriber: ashoat. · View Herald TranscriptJan 26 2023, 1:50 PM
atul published this revision for review.Jan 26 2023, 1:50 PM
Harbormaster completed remote builds in B15691: Diff 21396.Jan 26 2023, 2:05 PM
atul added a reviewer: ashoat.Jan 28 2023, 12:01 PM
ashoat accepted this revision.Jan 28 2023, 12:42 PM
This revision is now accepted and ready to land.Jan 28 2023, 12:42 PM
atul updated this revision to Diff 21501.Jan 28 2023, 12:58 PM

rebase before landing

This revision was landed with ongoing or failed builds.Jan 28 2023, 1:02 PM
Closed by commit rCOMMc0eeb2d6759c: [yarn] Run `yarn-deduplicate` to tidy up `yarn.lock` (authored by atul). · Explain Why
This revision was automatically updated to reflect the committed changes.
atul added a commit: rCOMMc0eeb2d6759c: [yarn] Run `yarn-deduplicate` to tidy up `yarn.lock`.
Harbormaster failed remote builds in B15769: Diff 21501!Jan 28 2023, 1:03 PM
atul added a reverting change: rCOMM6ee723cec222: Revert "[yarn] Run `yarn-deduplicate` to tidy up `yarn.lock`".Jan 28 2023, 1:27 PM
atul reopened this revision.Jan 28 2023, 1:28 PM

Well looks like there are flow issues after rebasing

This revision is now accepted and ready to land.Jan 28 2023, 1:28 PM
atul updated this revision to Diff 21513.Jan 28 2023, 1:42 PM

update

Harbormaster failed remote builds in B15771: Diff 21513!Jan 28 2023, 1:46 PM
atul abandoned this revision.Feb 27 2023, 11:13 PM

Revision Contents
Changeset List

PathSize
1719 lines

Diff 21396

View Options

yarn.lock

Loading...