Page MenuHomePhabricator

Remove react-native-notifications dependency from project
ClosedPublic

Authored by marcin on Jan 2 2023, 7:32 AM.
Tags
None
Referenced Files
F2155533: D6141.id20505.diff
Sun, Jun 30, 9:46 PM
F2154902: D6141.id21017.diff
Sun, Jun 30, 8:13 PM
F2154722: D6141.id21425.diff
Sun, Jun 30, 7:52 PM
F2154191: D6141.diff
Sun, Jun 30, 6:47 PM
F2152747: D6141.diff
Sun, Jun 30, 3:46 PM
Unknown Object (File)
Fri, Jun 28, 6:01 PM
Unknown Object (File)
Thu, Jun 27, 5:03 PM
Unknown Object (File)
Thu, Jun 27, 5:03 PM
Subscribers

Details

Summary

This differential removes react-native-notifications dependency from repo. changes in files were not created manually but by running: "yarn remove react-native-notifications" (in native directory) and then yarn cleaninstall (in project root).

Test Plan

Since all react-native-notifications are already removed and replaced, the only test plan we need is to successfully build the app

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

marcin requested review of this revision.Jan 2 2023, 7:47 AM

Exciting!!

native/react-native.config.js
6 ↗(On Diff #20505)

Good work catching this

This revision is now accepted and ready to land.Jan 3 2023, 10:34 AM