Page MenuHomePhabricator

[lib] add emoji tests file
ClosedPublic

Authored by ginsu on Jan 26 2023, 8:37 PM.
Tags
None
Referenced Files
F3500492: D6412.id21411.diff
Fri, Dec 20, 1:43 AM
F3498121: D6412.diff
Thu, Dec 19, 8:51 PM
Unknown Object (File)
Fri, Nov 29, 9:47 AM
Unknown Object (File)
Thu, Nov 28, 12:04 PM
Unknown Object (File)
Nov 11 2024, 8:38 AM
Unknown Object (File)
Nov 7 2024, 12:21 AM
Unknown Object (File)
Nov 1 2024, 3:12 AM
Unknown Object (File)
Oct 29 2024, 8:23 PM
Subscribers

Details

Summary

Readding emojis test file. For some reason when I landed D6398 this file got deleted.

Test Plan

flow and ran tests with the following results

Screenshot 2023-01-26 at 7.23.19 PM.png (642×1 px, 406 KB)

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

ginsu edited the test plan for this revision. (Show Details)
ginsu added reviewers: atul, tomek.
ginsu requested review of this revision.Jan 26 2023, 8:53 PM

How do you think the file was missed in the original land? Do you have multiple commits in your Git repo pointing to the same diff? That should generally be avoided, and you should also generally avoid doing things like arc diff --update

This revision is now accepted and ready to land.Jan 27 2023, 4:24 AM

How do you think the file was missed in the original land?

I landed both D6398 and D6399 at the same time by patching in D6399 by using arc patch D6399. My theory is that I didn't update D6399 in Phab with the rebase, which caused the file to be dropped. In the future, I will be more careful with this.

This revision was automatically updated to reflect the committed changes.

Encourage you to only use arc patch for pulling in other people's work going forward – it's typically a "crutch" for not understanding git well enough. Try to use git cherry-pick if you need to get a commit from another branch into the current one

Encourage you to only use arc patch for pulling in other people's work going forward – it's typically a "crutch" for not understanding git well enough. Try to use git cherry-pick if you need to get a commit from another branch into the current one

Gotcha moving forward I will make sure to do that