[keyserver] change reaction type from just like emoji to any emoji
ClosedPublic
Actions

Authored by ginsu on Jan 26 2023, 11:45 AM.

Details

Reviewers

atul
tomek
ashoat

Commits

rCOMM7a70f73090bb: [keyserver] change reaction type from just like emoji to any emoji

Summary

change reaction type from just like to any string. We will need to make this change so that any emoji can be used when creating a new reaction message

Depends on D6409
Linear Task: ENG-2776

Test Plan

flow and this will be futher tested in subsequent diffs, additionally all the jest tests below passed

Screenshot 2023-01-26 at 7.23.19 PM.png (642×1 px, 406 KB)

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

ginsu created this revision.Jan 26 2023, 11:45 AM

Herald added subscribers: atul, tomek, ashoat. · View Herald TranscriptJan 26 2023, 11:45 AM

ginsu added reviewers: atul, tomek.Jan 26 2023, 11:45 AM

Harbormaster completed remote builds in B15680: Diff 21382.Jan 26 2023, 12:00 PM

ginsu requested review of this revision.Jan 26 2023, 12:00 PM

ginsu edited the summary of this revision. (Show Details)Jan 26 2023, 12:02 PM

ginsu added a child revision: D6399: [web] introduce renderEmojiKeyboard and setRenderEmojiKeyboard to tooltip-provider.

Could an attacker hit this endpoint with a weird string and mess with things? It feels like we should introduce some sort of validation to make sure the input is good

In D6398#191658, @ashoat wrote:

Could an attacker hit this endpoint with a weird string and mess with things? It feels like we should introduce some sort of validation to make sure the input is good

Good point. I'll take a look and see if I can make a set for validation with the emoji data

ginsu planned changes to this revision.Jan 26 2023, 12:07 PM

address ashoat's feedback

Can you add something to the Test Plan about testing the validator? Would be easy to add some Jest test cases. I'd be particularly curious about composite emojis eg. skin tone emojis

Harbormaster completed remote builds in B15693: Diff 21398.Jan 26 2023, 3:01 PM

ginsu edited the summary of this revision. (Show Details)Jan 26 2023, 4:12 PM

ginsu added a parent revision: D6409: [lib] bump emoji-regex version to 10.2.1.

add jest tests for onlyOneEmojiRegex

ginsu retitled this revision from [keyserver] change reaction type from just like to any string to [keyserver] change reaction type from just like emoji to any emoji.Jan 26 2023, 4:23 PM

ginsu edited the test plan for this revision. (Show Details)

ginsu attached a referenced file: F346459: Screenshot 2023-01-26 at 7.23.19 PM.png. (Show Details)

Harbormaster completed remote builds in B15699: Diff 21404.Jan 26 2023, 4:36 PM

ashoat accepted this revision.Jan 26 2023, 5:43 PM

This revision is now accepted and ready to land.Jan 26 2023, 5:43 PM

Closed by commit rCOMM7a70f73090bb: [keyserver] change reaction type from just like emoji to any emoji (authored by ginsu). · Explain WhyJan 26 2023, 8:14 PM

This revision was automatically updated to reflect the committed changes.

ginsu added a commit: rCOMM7a70f73090bb: [keyserver] change reaction type from just like emoji to any emoji.

ginsu mentioned this in D6412: [lib] add emoji tests file.Jan 26 2023, 8:37 PM

ginsu mentioned this in rCOMMadc6be45d0b6: [lib] add emoji tests file.Jan 27 2023, 7:56 AM