Page MenuHomePhabricator
Differential D6399

[web] introduce renderEmojiKeyboard and setRenderEmojiKeyboard to tooltip-provider
ClosedPublic
Actions

Authored by ginsu on Jan 26 2023, 11:49 AM.
Tags
None
Referenced Files
F3234860: D6399.id21410.diff
Tue, Nov 12, 10:54 PM
F3234834: D6399.id21383.diff
Tue, Nov 12, 10:42 PM
Unknown Object (File)
Sun, Nov 10, 12:35 PM
Unknown Object (File)
Fri, Nov 1, 12:37 PM
Unknown Object (File)
Tue, Oct 29, 8:23 PM
Unknown Object (File)
Tue, Oct 29, 8:23 PM
Unknown Object (File)
Tue, Oct 29, 8:23 PM
Unknown Object (File)
Tue, Oct 29, 8:22 PM
View All 70 Files
Subscribers
ashoat
atul
tomek

Details

Reviewers
atul
tomek
Commits
rCOMMf5f65e7157d0: [web] introduce renderEmojiKeyboard and setRenderEmojiKeyboard to tooltip…
Summary

introduce renderEmojiKeyboard and setRenderEmojiKeyboard to tooltip-provider. renderEmojiKeyboard and setRenderEmojiKeyboard will be used to condionally render the emoji keyboard whenever the user clicks on the react button on the message tooltip. I will be introducing the react button in a subseqent diff.

Depends on D6398
Linear Task: ENG-2776

Test Plan

flow and this diff will be further tested in a subsequent diff

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

ginsu created this revision.Jan 26 2023, 11:49 AM
Herald added subscribers: atul, tomek, ashoat. · View Herald TranscriptJan 26 2023, 11:49 AM
ginsu added reviewers: atul, tomek.Jan 26 2023, 11:49 AM
ginsu edited the summary of this revision. (Show Details)Jan 26 2023, 12:03 PM
ginsu added a parent revision: D6398: [keyserver] change reaction type from just like emoji to any emoji.
Harbormaster completed remote builds in B15681: Diff 21383.Jan 26 2023, 12:03 PM
ginsu requested review of this revision.Jan 26 2023, 12:03 PM
ginsu added a child revision: D6401: [web] modify useOnClickReact to return function with arguments instead of passing arguments directly into hook.Jan 26 2023, 12:04 PM
atul requested changes to this revision.Jan 26 2023, 2:46 PM

Curious why setRenderEmojiKeyboard(...) is optional. Could totally just be missing something.

web/chat/tooltip-provider.js
30 ↗(On Diff #21383)

Why are we making setRenderEmojiKeyboard optional?

This revision now requires changes to proceed.Jan 26 2023, 2:46 PM
ginsu updated this revision to Diff 21399.Jan 26 2023, 2:58 PM

made setRenderEmojiKeyboard non optional

ginsu added a comment.Jan 26 2023, 2:58 PM

Curious why setRenderEmojiKeyboard(...) is optional. Could totally just be missing something.

No you are right, I don't know what I was thinking

Harbormaster completed remote builds in B15694: Diff 21399.Jan 26 2023, 3:12 PM
atul accepted this revision.Jan 26 2023, 3:34 PM
This revision is now accepted and ready to land.Jan 26 2023, 3:34 PM
Closed by commit rCOMMf5f65e7157d0: [web] introduce renderEmojiKeyboard and setRenderEmojiKeyboard to tooltip… (authored by ginsu). · Explain WhyJan 26 2023, 8:14 PM
This revision was automatically updated to reflect the committed changes.
ginsu added a commit: rCOMMf5f65e7157d0: [web] introduce renderEmojiKeyboard and setRenderEmojiKeyboard to tooltip….
ginsu mentioned this in D6412: [lib] add emoji tests file.Jan 27 2023, 7:54 AM

Revision Contents
Changeset List

PathSize
web/
chat/
14 lines

Diff 21410

View Options

web/chat/tooltip-provider.js

Loading...