Page MenuHomePhabricator

[keyserver] change reaction type from just like emoji to any emoji
ClosedPublic

Authored by ginsu on Jan 26 2023, 11:45 AM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Dec 19, 8:52 PM
Unknown Object (File)
Wed, Dec 18, 8:55 PM
Unknown Object (File)
Wed, Dec 18, 7:17 PM
Unknown Object (File)
Wed, Dec 18, 6:50 PM
Unknown Object (File)
Wed, Dec 18, 6:01 PM
Unknown Object (File)
Wed, Dec 18, 4:20 PM
Unknown Object (File)
Fri, Dec 6, 12:22 PM
Unknown Object (File)
Nov 1 2024, 12:38 PM
Subscribers

Details

Summary

change reaction type from just like to any string. We will need to make this change so that any emoji can be used when creating a new reaction message


Depends on D6409
Linear Task: ENG-2776

Test Plan

flow and this will be futher tested in subsequent diffs, additionally all the jest tests below passed

Screenshot 2023-01-26 at 7.23.19 PM.png (642×1 px, 406 KB)

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

Could an attacker hit this endpoint with a weird string and mess with things? It feels like we should introduce some sort of validation to make sure the input is good

Could an attacker hit this endpoint with a weird string and mess with things? It feels like we should introduce some sort of validation to make sure the input is good

Good point. I'll take a look and see if I can make a set for validation with the emoji data

address ashoat's feedback

Can you add something to the Test Plan about testing the validator? Would be easy to add some Jest test cases. I'd be particularly curious about composite emojis eg. skin tone emojis

add jest tests for onlyOneEmojiRegex

ginsu retitled this revision from [keyserver] change reaction type from just like to any string to [keyserver] change reaction type from just like emoji to any emoji.Jan 26 2023, 4:23 PM
ginsu edited the test plan for this revision. (Show Details)
This revision is now accepted and ready to land.Jan 26 2023, 5:43 PM