Page MenuHomePhabricator
Differential D6275

Stop subclassing RNFirebaseMessagingService as its functionality is not used anymore
ClosedPublic
Actions

Authored by marcin on Jan 16 2023, 6:04 AM.
Tags
None
Referenced Files
F3486727: D6275.diff
Wed, Dec 18, 5:46 AM
Unknown Object (File)
Sat, Dec 14, 3:51 AM
Unknown Object (File)
Sat, Dec 14, 3:51 AM
Unknown Object (File)
Sat, Dec 14, 3:51 AM
Unknown Object (File)
Sat, Dec 14, 3:51 AM
Unknown Object (File)
Sat, Dec 14, 3:51 AM
Unknown Object (File)
Sat, Dec 14, 3:50 AM
Unknown Object (File)
Sat, Dec 14, 3:40 AM
View All Files
Subscribers
ashoat
atul

Details

Reviewers
tomek
bartek
Commits
rCOMM53e6dc34d12d: Stop subclassing RNFirebaseMessagingService as its functionality is not used…
Summary

This differential removes RNFirebaseMessagingService from native Android codebase as its functionality is not used anymore. FirebaseMessagingService is now subclassed.

Test Plan

Build the app. All tests plans of differentials int ths stack under this one.

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

marcin created this revision.Jan 16 2023, 6:04 AM
Herald added subscribers: atul, ashoat. · View Herald TranscriptJan 16 2023, 6:04 AM
marcin added a parent revision: D6274: Send broadcast from CommNotificationsHandler when foreground notification is received. Forward parsed notification to JavaScript.Jan 16 2023, 6:04 AM
Harbormaster completed remote builds in B15383: Diff 20975.Jan 16 2023, 6:17 AM
marcin requested review of this revision.Jan 16 2023, 6:17 AM
marcin added a child revision: D6295: Modify notification displayed from Java so that it opens the app when clicked.Jan 18 2023, 6:50 AM
tomek accepted this revision.Jan 18 2023, 9:53 AM

Are we still using io.invertase.firebase.messaging anywhere?

native/android/app/src/main/java/app/comm/android/notifications/CommNotificationsHandler.java
26–50 ↗(On Diff #20975)

We have to update (or delete) this comment

This revision is now accepted and ready to land.Jan 18 2023, 9:53 AM
bartek accepted this revision.Jan 19 2023, 10:12 AM
marcin added inline comments.Jan 26 2023, 4:38 AM
native/android/app/src/main/java/app/comm/android/notifications/CommNotificationsHandler.java
26–50 ↗(On Diff #20975)

This comment provides an explanation why we cannot subclass FirebaseMessagingService directly yet. Now that we implemented direct subclassing we probably should just delete it, so I will proceed this way.

marcin updated this revision to Diff 21364.Jan 26 2023, 7:42 AM

Remove comment explaining why this class subclasses RNFirebaseMessagingService, since it no longer subclasses RNFirebaseMessagingService

Harbormaster completed remote builds in B15667: Diff 21364.Jan 26 2023, 7:57 AM
marcin updated this revision to Diff 21452.Jan 27 2023, 6:39 AM

Rebase before landing

Harbormaster completed remote builds in B15731: Diff 21452.Jan 27 2023, 6:53 AM
marcin updated this revision to Diff 21568.Jan 30 2023, 3:09 AM

Rebase before landing

Harbormaster completed remote builds in B15822: Diff 21568.Jan 30 2023, 3:24 AM
Closed by commit rCOMM53e6dc34d12d: Stop subclassing RNFirebaseMessagingService as its functionality is not used… (authored by marcin). · Explain WhyJan 30 2023, 4:12 AM
This revision was automatically updated to reflect the committed changes.
marcin added a commit: rCOMM53e6dc34d12d: Stop subclassing RNFirebaseMessagingService as its functionality is not used….

Revision Contents
Changeset List

PathSize
native/
android/
app/
src/
main/
1 line
java/
app/
comm/
android/
notifications/
29 lines

Diff 21568

View Options

native/android/app/src/main/AndroidManifest.xml

Loading...
View Options

native/android/app/src/main/java/app/comm/android/notifications/CommNotificationsHandler.java

Loading...