Differential D6366

Implement native method to get initial notification and use it in JavaScript
ClosedPublic
Actions

Authored by marcin on Jan 24 2023, 1:05 PM.

Tags

None

Referenced Files

	F3486738: D6366.diff
	Wed, Dec 18, 5:51 AM

	Unknown Object (File)
	Sat, Dec 14, 3:51 AM

	Unknown Object (File)
	Sat, Dec 14, 3:51 AM

	Unknown Object (File)
	Sat, Dec 14, 3:51 AM

	Unknown Object (File)
	Sat, Dec 14, 3:51 AM

	Unknown Object (File)
	Sat, Dec 14, 3:50 AM

	Unknown Object (File)
	Sat, Dec 14, 3:40 AM

	Unknown Object (File)
	Nov 14 2024, 10:29 AM

Subscribers

Details

Reviewers

tomek
bartek

Commits

rCOMM9dc4d971b9b1: Implement native method to get initial notification and use it in JavaScript

Summary

This differential implements native method to get initial notification - notification which delivery and tapping booted the app - and uses it in JavaScript. CommAndroidNotifications module
typing is updated as well.

Test Plan

Add logging to log initialNotif from JavaScript. Build the app. Kill it. Send notification. Tap it. Ensure the content of notification is displayed in metro console and it is valid.

Diff Detail

Repository

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

marcin created this revision.Jan 24 2023, 1:05 PM

Herald added subscribers: atul, tomek, ashoat. · View Herald TranscriptJan 24 2023, 1:05 PM

marcin added a parent revision: D6296: Send event to JavaScript when notification is tapped so that we navigate to the thread.Jan 24 2023, 1:05 PM

marcin added reviewers: tomek, bartek.Jan 24 2023, 1:12 PM

Harbormaster completed remote builds in B15604: Diff 21270.Jan 24 2023, 1:19 PM

marcin requested review of this revision.Jan 24 2023, 1:19 PM

marcin added a child revision: D6377: Implement native method to create notification channel.Jan 25 2023, 12:43 AM

tomek accepted this revision.Jan 26 2023, 2:03 AM

This revision is now accepted and ready to land.Jan 26 2023, 2:03 AM

bartek accepted this revision.Jan 26 2023, 4:47 AM

Rebase before landing

Harbormaster completed remote builds in B15734: Diff 21455.Jan 27 2023, 6:55 AM

Rebase before landing

Harbormaster completed remote builds in B15825: Diff 21571.Jan 30 2023, 3:29 AM

Closed by commit rCOMM9dc4d971b9b1: Implement native method to get initial notification and use it in JavaScript (authored by marcin). · Explain WhyJan 30 2023, 4:12 AM

This revision was automatically updated to reflect the committed changes.

marcin added a commit: rCOMM9dc4d971b9b1: Implement native method to get initial notification and use it in JavaScript.

Revision Contents
Changeset List

Path

Size

native/

android/

app/

src/

main/

java/

app/

comm/

android/

notifications/

CommAndroidNotifications.java

17 lines

push/

1 line

push-handler.react.js

4 lines

Diff 21571

native/android/app/src/main/java/app/comm/android/notifications/CommAndroidNotifications.java

Loading...

native/push/android.js

Loading...

native/push/push-handler.react.js

Loading...