Page MenuHomePhabricator

Move CommNotificationsHandler to newly created notifications package
ClosedPublic

Authored by marcin on Jan 11 2023, 3:58 AM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Dec 18, 7:45 AM
Unknown Object (File)
Wed, Dec 18, 7:43 AM
Unknown Object (File)
Wed, Dec 18, 7:27 AM
Unknown Object (File)
Wed, Dec 18, 7:25 AM
Unknown Object (File)
Wed, Dec 18, 4:44 AM
Unknown Object (File)
Sat, Dec 14, 3:50 AM
Unknown Object (File)
Sat, Dec 14, 3:50 AM
Unknown Object (File)
Sat, Dec 14, 3:50 AM
Subscribers

Details

Summary

This differential creates specialized package for code intended to deal with notifications and places CommNotificationsHandler there. Future differentials will add more files to this package

Test Plan

This differential brings no functional change. Build the app and ensure that notification displaying (foreground and background) as well as rescinding works the same.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

native/android/app/src/main/java/app/comm/android/notifications/CommNotificationsHandler.java
1 ↗(On Diff #20782)

What's the benefit of this custom package?

native/android/app/src/main/java/app/comm/android/notifications/CommNotificationsHandler.java
1 ↗(On Diff #20782)
This revision is now accepted and ready to land.Jan 11 2023, 8:55 AM
native/android/app/src/main/java/app/comm/android/notifications/CommNotificationsHandler.java
1 ↗(On Diff #20782)

I decided to move this file to separate directory since future differentials in this stack will introduce additional files to handle notifications functionality. I think keeping them in dedicated directory keeps code tidy and uncluttered.