Page MenuHomePhabricator
Differential D6486

[lib] Add `emote-smile-filled` to `CommIcons`
ClosedPublic
Actions

Authored by atul on Jan 31 2023, 11:11 AM.
Tags
None
Referenced Files
F3488046: D6486.diff
Wed, Dec 18, 8:50 AM
Unknown Object (File)
Fri, Dec 6, 12:21 PM
Unknown Object (File)
Fri, Nov 22, 2:23 AM
Unknown Object (File)
Fri, Nov 22, 2:23 AM
Unknown Object (File)
Fri, Nov 22, 2:22 AM
Unknown Object (File)
Nov 13 2024, 5:38 AM
Unknown Object (File)
Nov 13 2024, 5:38 AM
Unknown Object (File)
Nov 13 2024, 5:38 AM
View All 75 Files
Subscribers
None

Details

Reviewers
ashoat
tomek
ginsu
rohan
Commits
rCOMM7f30e26bce4c: [lib] Add `emote-smile-filled` to `CommIcons`
Summary

Context: https://linear.app/comm/issue/ENG-2886/implement-new-react-icon-for-web-tooltip

Test Plan

Here's what it looks like:

f18890.png (568×2 px, 180 KB)

a119c7.png (220×1 px, 41 KB)

Diff Detail

Repository
rCOMM Comm
Branch
arcpatch-D6486 (branched from master)
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

atul created this revision.Jan 31 2023, 11:11 AM
atul edited the test plan for this revision. (Show Details)Jan 31 2023, 11:12 AM
atul added inline comments.
lib/shared/comm-icon-config.json
59–63 ↗(On Diff #21700)

Bunch of this stuff got re-arranged, whatever

atul published this revision for review.Jan 31 2023, 11:13 AM
Harbormaster completed remote builds in B15899: Diff 21700.Jan 31 2023, 11:30 AM
ginsu accepted this revision.Jan 31 2023, 11:59 AM

thanks @atul!

This revision is now accepted and ready to land.Jan 31 2023, 11:59 AM
atul updated this revision to Diff 21702.Jan 31 2023, 12:05 PM

rebase before landing

atul added a comment.Jan 31 2023, 12:06 PM

Landing without "blocking reviewer" approval because @ginsu is the right person to review this (https://linear.app/comm/issue/ENG-2648/get-rid-of-formal-blocking-reviewers-requirement).

This revision was landed with ongoing or failed builds.Jan 31 2023, 12:07 PM
Closed by commit rCOMM7f30e26bce4c: [lib] Add `emote-smile-filled` to `CommIcons` (authored by atul). · Explain Why
This revision was automatically updated to reflect the committed changes.
atul added a commit: rCOMM7f30e26bce4c: [lib] Add `emote-smile-filled` to `CommIcons`.
Harbormaster completed remote builds in B15901: Diff 21702.Jan 31 2023, 12:29 PM

Revision Contents
Changeset List

PathSize
lib/
shared/
95 lines
native/
fonts/
web/
3 lines
utils/
3 lines

Diff 21702

View Options

lib/shared/comm-icon-config.json

Loading...
View Options

native/fonts/CommIcons.ttf

Loading...
View Options

web/CommIcon.react.js

Loading...
View Options

web/utils/tooltip-utils.js

Loading...