[native] introduce showEmojiKeyboard shared value
ClosedPublic
Actions

Authored by ginsu on Jan 29 2023, 2:40 PM.

Details

Reviewers

atul
tomek

Commits

rCOMM3c1984661190: [native] introduce showEmojiKeyboard shared value

Summary

introduce showEmojiKeyboard shared value. This will be used to open/close the emoji keyboard and open/close the tooltip, which will be implemented in a subsequent diff.

Also noticed as developing that setHideTooltip would be better typed as SetState<boolean> so included that change in this diff.

Linear Task: ENG-2777

Test Plan

flow and diff will be further tested in subsequent diffs

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

ginsu created this revision.Jan 29 2023, 2:40 PM

Herald added subscribers: atul, tomek, ashoat. · View Herald TranscriptJan 29 2023, 2:40 PM

ginsu edited the summary of this revision. (Show Details)Jan 29 2023, 2:41 PM

ginsu added reviewers: atul, tomek.

ginsu edited the summary of this revision. (Show Details)

ginsu edited the summary of this revision. (Show Details)Jan 29 2023, 2:45 PM

Harbormaster completed remote builds in B15788: Diff 21534.Jan 29 2023, 2:54 PM

ginsu requested review of this revision.Jan 29 2023, 2:54 PM

ginsu added a child revision: D6447: [native] change location to tooltipLocation in the TooltipParams.Jan 29 2023, 2:57 PM

tomek requested changes to this revision.Jan 30 2023, 4:39 AM

tomek added inline comments.

native/navigation/tooltip.react.js
749–750 ↗	(On Diff #21534)	Why do we want to block going back when a keyboard is visible? Was it discussed somewhere?

This revision now requires changes to proceed.Jan 30 2023, 4:39 AM

ginsu added inline comments.Jan 30 2023, 12:20 PM

native/navigation/tooltip.react.js
749–750 ↗	(On Diff #21534)	This callback/worklet gets called whenever the tooltip component exits. We are going to want to have the tooltip exit when the emoji keyboard is shown so that the tooltip does not block the emoji keyboard; however, we want to make sure that we do not navigate back. Otherwise, this will close everything in the modal, including the emoji keyboard