Page MenuHomePhabricator
Differential D6502

[web] Rename `SIWE` component to `SIWELoginForm`
ClosedPublic
Actions

Authored by atul on Feb 1 2023, 1:09 PM.
Tags
None
Referenced Files
F3505241: D6502.diff
Fri, Dec 20, 12:51 PM
Unknown Object (File)
Nov 18 2024, 7:28 AM
Unknown Object (File)
Nov 1 2024, 12:58 PM
Unknown Object (File)
Nov 1 2024, 12:58 PM
Unknown Object (File)
Nov 1 2024, 12:57 PM
Unknown Object (File)
Nov 1 2024, 12:34 PM
Unknown Object (File)
Oct 29 2024, 7:20 PM
Unknown Object (File)
Oct 29 2024, 7:20 PM
View All 55 Files
Subscribers
None

Details

Reviewers
ashoat
tomek
rohan
ginsu
Commits
rCOMM9ccf13a869da: [web] Rename `SIWE` component to `SIWELoginForm`
Summary

Clearer name and also parallel naming structure to TraditionalLoginForm and also distinguishes from SIWE component in landing.

Test Plan

NA, flow + things work as expected + searched codebase for usages of the web SIWE component and this was the only one.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

atul created this revision.Feb 1 2023, 1:09 PM
atul published this revision for review.Feb 1 2023, 1:11 PM
ashoat accepted this revision.Feb 1 2023, 1:13 PM
This revision is now accepted and ready to land.Feb 1 2023, 1:13 PM
This revision was landed with ongoing or failed builds.Feb 1 2023, 1:20 PM
Closed by commit rCOMM9ccf13a869da: [web] Rename `SIWE` component to `SIWELoginForm` (authored by atul). · Explain Why
This revision was automatically updated to reflect the committed changes.
atul added a commit: rCOMM9ccf13a869da: [web] Rename `SIWE` component to `SIWELoginForm`.
Harbormaster completed remote builds in B15954: Diff 21786.Feb 1 2023, 1:27 PM

Revision Contents
Changeset List

PathSize
web/
account/
4 lines
4 lines

Diff 21790

View Options

web/account/log-in-form.react.js

Loading...
View Options

web/account/siwe-login-form.react.js

Loading...
View Options

web/account/siwe.react.js

Loading...