Paths

Table of Contentst

[lib] Convert ChangeRole robotext to use EntityText
ClosedPublic
Actions

Authored by ashoat on Feb 1 2023, 3:37 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sat, Dec 14, 1:30 PM

	Unknown Object (File)
	Sat, Dec 14, 1:30 PM

	Unknown Object (File)
	Sat, Dec 14, 1:29 PM

	Unknown Object (File)
	Sat, Dec 14, 1:23 PM

	Unknown Object (File)
	Nov 14 2024, 8:18 PM

	Unknown Object (File)
	Nov 14 2024, 8:18 PM

	Unknown Object (File)
	Nov 14 2024, 8:18 PM

	Unknown Object (File)
	Oct 26 2024, 9:22 PM

View All 87 Files

Subscribers

tomek

Details

Reviewers

atul

Commits

rCOMM950fbd9cd274: [lib] Convert ChangeRole robotext to use EntityText

Summary

Depends on D6513

Test Plan

Looked at a ChangeRole robotext on web and native, both from the perspective of the viewer and of somebody else

Diff Detail

Repository

rCOMM Comm

Branch

ashoat/ens

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

ashoat created this revision.Feb 1 2023, 3:37 PM

Herald added a subscriber: tomek. · View Herald TranscriptFeb 1 2023, 3:37 PM

Harbormaster completed remote builds in B15973: Diff 21814.Feb 1 2023, 4:02 PM

ashoat requested review of this revision.Feb 1 2023, 4:02 PM

ashoat added a child revision: D6515: [lib] Convert JoinThread/LeaveThread robotext to use EntityText.Feb 1 2023, 4:16 PM

atul accepted this revision.Feb 2 2023, 10:53 AM

This revision is now accepted and ready to land.Feb 2 2023, 10:53 AM

Closed by commit rCOMM950fbd9cd274: [lib] Convert ChangeRole robotext to use EntityText (authored by ashoat). · Explain WhyFeb 2 2023, 11:41 AM

This revision was automatically updated to reflect the committed changes.

ashoat added a commit: rCOMM950fbd9cd274: [lib] Convert ChangeRole robotext to use EntityText.

Revision Contents
Changeset List

Path

Size

lib/

shared/

messages/

change-role-message-spec.js

19 lines

Diff 21814

View Options

lib/shared/messages/change-role-message-spec.js

[lib] Convert ChangeRole robotext to use EntityTextClosedPublicActions