[lib] Convert JoinThread/LeaveThread robotext to use EntityText
ClosedPublic
Actions

Authored by ashoat on Feb 1 2023, 3:48 PM.

Details

Reviewers

atul

Commits

rCOMM6372f7462204: [lib] Convert JoinThread/LeaveThread robotext to use EntityText

Test Plan

Looked at a JoinThread robotext on web and native, both from the perspective of the viewer and of somebody else

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

ashoat created this revision.Feb 1 2023, 3:48 PM

Herald added a subscriber: tomek. · View Herald TranscriptFeb 1 2023, 3:48 PM

Harbormaster completed remote builds in B15975: Diff 21816.Feb 1 2023, 4:09 PM

ashoat requested review of this revision.Feb 1 2023, 4:09 PM

ashoat edited parent revisions, added: D6514: [lib] Convert ChangeRole robotext to use EntityText; removed: D6512: [lib] Convert AddMembers/RemoveMembers robotext to use EntityText.Feb 1 2023, 4:16 PM

ashoat edited the summary of this revision. (Show Details)

ashoat added a child revision: D6516: [lib] Convert entry robotexts to use EntityText.Feb 1 2023, 4:17 PM

Don't include "this" as it's handled by ThreadEntity now

Harbormaster completed remote builds in B15979: Diff 21820.Feb 1 2023, 5:20 PM

ashoat mentioned this in D6509: [lib] Add helpers for EntityText.Feb 2 2023, 8:39 AM

atul accepted this revision.Feb 2 2023, 10:53 AM

This revision is now accepted and ready to land.Feb 2 2023, 10:53 AM

Closed by commit rCOMM6372f7462204: [lib] Convert JoinThread/LeaveThread robotext to use EntityText (authored by ashoat). · Explain WhyFeb 2 2023, 11:41 AM

This revision was automatically updated to reflect the committed changes.

ashoat added a commit: rCOMM6372f7462204: [lib] Convert JoinThread/LeaveThread robotext to use EntityText.

Revision Contents
Changeset List

Path

Size

lib/

shared/

messages/

join-thread-message-spec.js

17 lines

leave-thread-message-spec.js

17 lines

Diff 21820

View Options

lib/shared/messages/join-thread-message-spec.js