[scripts] make install_protobuf script work on macos
ClosedPublic
Actions

Authored by varun on Feb 2 2023, 8:33 AM.

Tags

None

Referenced Files

	F3492445: D6525.id21865.diff
	Wed, Dec 18, 11:59 PM

	F3492412: D6525.id21856.diff
	Wed, Dec 18, 11:45 PM

	F3491878: D6525.diff
	Wed, Dec 18, 9:03 PM

	Unknown Object (File)
	Sat, Dec 14, 4:14 AM

	Unknown Object (File)
	Sat, Dec 14, 4:14 AM

	Unknown Object (File)
	Sat, Dec 14, 4:14 AM

	Unknown Object (File)
	Sat, Dec 14, 4:07 AM

	Unknown Object (File)
	Thu, Nov 21, 5:18 AM

Subscribers

Details

Reviewers

• jon

Commits

rCOMM132c2ddb0111: [scripts] make install_protobuf script work on macos

Summary

nproc isn't a command on macos, so we need to use sysctl if it's not available

Test Plan

CI passes

Diff Detail

Repository

rCOMM Comm

Branch

master

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

varun created this revision.Feb 2 2023, 8:33 AM

Herald added subscribers: atul, tomek, ashoat. · View Herald TranscriptFeb 2 2023, 8:33 AM

Harbormaster completed remote builds in B16011: Diff 21856.Feb 2 2023, 8:52 AM

varun requested review of this revision.Feb 2 2023, 8:52 AM

• jon accepted this revision.Feb 2 2023, 8:56 AM

This revision is now accepted and ready to land.Feb 2 2023, 8:56 AM

Closed by commit rCOMM132c2ddb0111: [scripts] make install_protobuf script work on macos (authored by varun). · Explain WhyFeb 2 2023, 9:06 AM

This revision was automatically updated to reflect the committed changes.

varun added a commit: rCOMM132c2ddb0111: [scripts] make install_protobuf script work on macos.

Revision Contents
Changeset List

Path

Size

scripts/

install_protobuf.sh

2 lines

Diff 21856

View Options

scripts/install_protobuf.sh

[scripts] make install_protobuf script work on macosClosedPublicActions