Page MenuHomePhabricator
Differential D6538

[native] add SafeAreaView to MessageReactionsModal
ClosedPublic
Actions

Authored by ginsu on Feb 2 2023, 12:37 PM.
Tags
None
Referenced Files
F3503952: D6538.id21925.diff
Fri, Dec 20, 6:52 AM
F3500421: D6538.diff
Fri, Dec 20, 1:33 AM
Unknown Object (File)
Thu, Nov 21, 5:18 AM
Unknown Object (File)
Thu, Nov 21, 5:18 AM
Unknown Object (File)
Nov 18 2024, 7:29 PM
Unknown Object (File)
Nov 15 2024, 11:38 PM
Unknown Object (File)
Oct 29 2024, 5:51 PM
Unknown Object (File)
Oct 13 2024, 2:26 AM
View All 97 Files
Subscribers
ashoat
atul
tomek

Details

Reviewers
atul
tomek
rohan
Commits
rCOMMfea59cff31f5: [native] add SafeAreaView to MessageReactionsModal
Summary

add SafeAreaView to MessageReactionsModal. The SafeAreaView pushes the container of MessageReactionsModal up a bit to a place where things like the Android nav buttons won't overlap with the content of the modal

Linear Task: ENG-2846

Test Plan

Please review the screenshots below to see the changes I made

Before:

iOS:

Screenshot 2023-02-02 at 3.32.11 PM.png (1×1 px, 852 KB)

Android:

Screenshot 2023-02-02 at 1.17.10 PM.png (1×978 px, 415 KB)

After:

iOS:

Screenshot 2023-02-02 at 3.30.59 PM.png (1×1 px, 850 KB)

Android:

Screenshot 2023-02-02 at 3.29.27 PM.png (1×978 px, 422 KB)

Diff Detail

Repository
rCOMM Comm
Branch
eng-2846
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

ginsu created this revision.Feb 2 2023, 12:37 PM
Herald added subscribers: atul, tomek, ashoat. · View Herald TranscriptFeb 2 2023, 12:37 PM
ginsu edited the summary of this revision. (Show Details)Feb 2 2023, 12:41 PM
ginsu edited the test plan for this revision. (Show Details)
ginsu added reviewers: atul, tomek, rohan.
ginsu attached a referenced file: F358614: Screenshot 2023-02-02 at 3.29.27 PM.png. (Show Details)
ginsu attached a referenced file: F358613: Screenshot 2023-02-02 at 3.30.59 PM.png. (Show Details)
ginsu attached a referenced file: F358612: Screenshot 2023-02-02 at 1.17.10 PM.png. (Show Details)
ginsu attached a referenced file: F358611: Screenshot 2023-02-02 at 3.32.11 PM.png. (Show Details)
Harbormaster completed remote builds in B16028: Diff 21900.Feb 2 2023, 12:49 PM
ginsu requested review of this revision.Feb 2 2023, 12:49 PM
atul accepted this revision.Feb 2 2023, 3:46 PM
This revision is now accepted and ready to land.Feb 2 2023, 3:46 PM
Closed by commit rCOMMfea59cff31f5: [native] add SafeAreaView to MessageReactionsModal (authored by ginsu). · Explain WhyFeb 2 2023, 8:13 PM
This revision was automatically updated to reflect the committed changes.
ginsu added a commit: rCOMMfea59cff31f5: [native] add SafeAreaView to MessageReactionsModal.
ashoat added inline comments.Feb 3 2023, 10:55 AM
native/chat/message-reactions-modal.react.js
65 ↗(On Diff #21925)

There's no reason to nest a SafeAreaView inside another SafeAreaView

ashoat added inline comments.Feb 3 2023, 11:03 AM
native/chat/message-reactions-modal.react.js
65 ↗(On Diff #21925)

Never mind, ignore this! I confused myself

Revision Contents
Changeset List

PathSize
native/
chat/
40 lines

Diff 21900

View Options

native/chat/message-reactions-modal.react.js

Loading...