[CI] Run mobile releases on push git tag "mobile-vX.Y.Z"
ClosedPublic
Actions

Authored by michal on Feb 3 2023, 3:12 AM.

Details

Reviewers

atul
• jon

Commits

rCOMMe68e97ba241e: [CI] Run mobile releases on push git tag "mobile-vX.Y.Z"

Summary

Part of the ENG-2224. Now we will have both mobile and desktop releases on GitHub so we need to differentiate them. This diff changes the Android/ iOS trigger from release published to tag push that starts with mobile-.

Test Plan

Tested on a fork: https://github.com/MichalGniadek/comm-test-gh

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

michal created this revision.Feb 3 2023, 3:12 AM

Herald added subscribers: tomek, ashoat. · View Herald TranscriptFeb 3 2023, 3:12 AM

Harbormaster completed remote builds in B16062: Diff 21936.Feb 3 2023, 3:27 AM

michal requested review of this revision.Feb 3 2023, 3:27 AM

Hm, it would still be good to have it kick off on release instead of tag

This revision now requires changes to proceed.Feb 4 2023, 12:02 PM

Ugh actually it looks like there's no easy way to trigger on publish and check the tag. This is probably fine

This revision is now accepted and ready to land.Feb 4 2023, 12:03 PM

Closed by commit rCOMMe68e97ba241e: [CI] Run mobile releases on push git tag "mobile-vX.Y.Z" (authored by Michal Gniadek <michal.gniadek@swmansion.com>). · Explain WhyFeb 9 2023, 1:39 AM

This revision was automatically updated to reflect the committed changes.

Michal Gniadek <michal.gniadek@swmansion.com> added a commit: rCOMMe68e97ba241e: [CI] Run mobile releases on push git tag "mobile-vX.Y.Z".

Revision Contents
Changeset List

Path

Size

.github/

workflows/

android_release.yml

5 lines

ios_release.yml

5 lines

Diff 21936

View Options

.github/workflows/android_release.yml