Page MenuHomePhabricator

[lib][web][native] Fetch ENS names for sidebar preview
ClosedPublic

Authored by ashoat on Feb 3 2023, 12:20 PM.
Tags
None
Referenced Files
F3294207: D6567.diff
Sat, Nov 16, 6:47 PM
Unknown Object (File)
Mon, Oct 28, 12:39 AM
Unknown Object (File)
Mon, Oct 28, 12:39 AM
Unknown Object (File)
Mon, Oct 28, 12:38 AM
Unknown Object (File)
Oct 14 2024, 10:40 PM
Unknown Object (File)
Oct 14 2024, 4:16 PM
Unknown Object (File)
Sep 28 2024, 4:21 AM
Unknown Object (File)
Sep 20 2024, 1:10 AM
Subscribers

Details

Summary

With this diff, message titles are now handled by EntityText, and the EntityText is fully resolved at all relevant callsites.

Depends on D6566

Test Plan

Add artificial delays to ENS fetching and confirm delays reflected in sidebar creation, and that sidebar title in UI includes resolved ENS names.

Note that there are two places in native that I decided not to fetch ENS names in: SidebarInputBarHeightMeasurer and useAnimatedMessageTooltipButton. I checked and both of these places don't look at the thread title. The former handles height measurement and the latter handles animations. In both cases a hook would be inappropriate as it would cause the process (height measurement or animation setup) to have to be done twice (once after ENS resolution), which would be would be performance/efficiency with no benefit. Using an async function here would avoid forcing things to happen twice, but it would unnecessarily delay things and make performance worse.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable