Page MenuHomePhabricator
Differential D6532

[Nix] Only prompt for direnv usage on install
ClosedPublic
Actions

Authored by • jon on Feb 2 2023, 9:59 AM.
Tags
None
Referenced Files
F4085997: D6532.id21869.diff
Sun, Feb 16, 7:54 AM
F4085996: D6532.id22127.diff
Sun, Feb 16, 7:54 AM
F4085970: D6532.id.diff
Sun, Feb 16, 7:54 AM
F4085947: D6532.diff
Sun, Feb 16, 7:48 AM
Unknown Object (File)
Jan 13 2025, 11:47 PM
Unknown Object (File)
Jan 2 2025, 12:25 AM
Unknown Object (File)
Dec 31 2024, 8:31 PM
Unknown Object (File)
Dec 31 2024, 8:31 PM
View All 66 Files
Subscribers
tomek

Details

Reviewers
ashoat
varun
atul
bartek
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Commits
rCOMMaa565352bba0: [Nix] Only prompt for direnv usage on install
Summary

It's actually quite hard to determine if a shell is interactive
between difference shells and environments.

Move the prompt to use direnv to the install_nix.sh script to condense
all possible prompt interactions into a single script.

https://linear.app/comm/issue/ENG-2847

Test Plan
rm -rf ~/Library/Caches/app.comm/install-direnv
brew uninstall direnv

./scripts/install_nix.sh

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

• jon created this revision.Feb 2 2023, 9:59 AM
Owners added a reviewer: Restricted Owners Package.Feb 2 2023, 9:59 AM
Herald added a subscriber: tomek. · View Herald TranscriptFeb 2 2023, 9:59 AM
Harbormaster completed remote builds in B16022: Diff 21869.Feb 2 2023, 10:16 AM
• jon requested review of this revision.Feb 2 2023, 10:16 AM
ashoat accepted this revision.Feb 2 2023, 11:42 AM

Mostly rubberstamping as I'm not very familiar with this code

varun accepted this revision.Feb 2 2023, 1:07 PM
This revision is now accepted and ready to land.Feb 2 2023, 1:07 PM
Closed by commit rCOMMaa565352bba0: [Nix] Only prompt for direnv usage on install (authored by • jon). · Explain WhyFeb 6 2023, 7:17 AM
This revision was automatically updated to reflect the committed changes.
• jon added a commit: rCOMMaa565352bba0: [Nix] Only prompt for direnv usage on install.

Revision Contents
Changeset List

PathSize
nix/
2 lines
scripts/
5 lines
2 lines

Diff 22127

View Options

nix/dev-shell.nix

Loading...
View Options

scripts/install_nix.sh

Loading...
View Options

scripts/prompt_direnv_macos.sh

Loading...