[native] Add `copy-filled` icon to `CommIcons.ttf`
ClosedPublic
Actions

Authored by atul on Feb 6 2023, 11:40 AM.

Tags

None

Referenced Files

	F3294469: D6631.id22149.diff
	Sat, Nov 16, 6:57 PM

	F3292608: D6631.diff
	Sat, Nov 16, 4:41 PM

	Unknown Object (File)
	Tue, Oct 29, 5:54 PM

	Unknown Object (File)
	Tue, Oct 29, 5:54 PM

	Unknown Object (File)
	Tue, Oct 29, 5:51 PM

	Unknown Object (File)
	Oct 8 2024, 4:39 AM

	Unknown Object (File)
	Oct 8 2024, 4:28 AM

	Unknown Object (File)
	Sep 30 2024, 5:55 AM

View All 71 Files

Subscribers

None

Details

Reviewers

tomek
ginsu
rohan
varun

Commits

rCOMM63785b238c43: [native] Add `copy-filled` icon to `CommIcons.ttf`

Summary

Context: https://linear.app/comm/issue/ENG-2579/add-copy-filled-icon-to-native-icons-font

Test Plan

Looks as expected:

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

atul created this revision.Feb 6 2023, 11:40 AM

atul published this revision for review.Feb 6 2023, 11:41 AM

atul edited the test plan for this revision. (Show Details)

atul edited reviewers, added: ginsu, rohan, varun; removed: ashoat.Feb 6 2023, 11:50 AM

ginsu accepted this revision.Feb 6 2023, 11:51 AM

This revision is now accepted and ready to land.Feb 6 2023, 11:51 AM

Harbormaster completed remote builds in B16185: Diff 22148.Feb 6 2023, 11:53 AM

Closed by commit rCOMM63785b238c43: [native] Add `copy-filled` icon to `CommIcons.ttf` (authored by atul). · Explain WhyFeb 6 2023, 11:54 AM

This revision was automatically updated to reflect the committed changes.

atul added a commit: rCOMM63785b238c43: [native] Add `copy-filled` icon to `CommIcons.ttf`.

Revision Contents
Changeset List

Path

Size

lib/

shared/

comm-icon-config.json

10 lines

native/

fonts/

CommIcons.ttf

Diff 22149

View Options

lib/shared/comm-icon-config.json