Page MenuHomePhabricator

[lib] Replace optimize-css-assets-webpack-plugin with css-minimizer-webpack-plugin
ClosedPublic

Authored by ashoat on Feb 12 2023, 6:51 PM.
Tags
None
Referenced Files
F3487092: D6701.id22385.diff
Wed, Dec 18, 6:56 AM
F3487088: D6701.id22355.diff
Wed, Dec 18, 6:54 AM
F3486157: D6701.diff
Wed, Dec 18, 3:50 AM
F3484519: D6701.diff
Tue, Dec 17, 2:25 PM
Unknown Object (File)
Sat, Dec 14, 3:19 PM
Unknown Object (File)
Thu, Dec 5, 5:04 PM
Unknown Object (File)
Tue, Dec 3, 3:35 PM
Unknown Object (File)
Tue, Dec 3, 11:27 AM
Subscribers
None

Details

Summary

See the README for optimize-css-assets-webpack-plugin:

For webpack v5 or above please use css-minimizer-webpack-plugin instead.

This gets rid of a warning that was previously printing when generating a production Webpack build:

[DEP_WEBPACK_COMPILATION_OPTIMIZE_CHUNK_ASSETS] DeprecationWarning: optimizeChunkAssets is deprecated (use Compilation.hooks.processAssets instead and use one of Compilation.PROCESS_ASSETS_STAGE_* as stage option)

Depends on D6700

Test Plan
  1. Confirm the depercation warning goes away
  2. I ran yarn prod in landing and web (we only use this plugin in prod builds) and then tested the website by running keyserver with yarn prod-build && yarn-prod

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

Harbormaster returned this revision to the author for changes because remote builds failed.Feb 12 2023, 7:02 PM
Harbormaster failed remote builds in B16353: Diff 22355!

Please ignore failing CI – it's intentional, otherwise this diff would be too big and difficult to review

This revision is now accepted and ready to land.Feb 12 2023, 7:31 PM
This revision was landed with ongoing or failed builds.Feb 12 2023, 8:08 PM
This revision was automatically updated to reflect the committed changes.