Page MenuHomePhabricator
Differential D6702

[lib] Use Webpack 5 asset/inline instead of deprecated url-loader
ClosedPublic
Actions

Authored by ashoat on Feb 12 2023, 6:54 PM.
Tags
None
Referenced Files
F3486080: D6702.diff
Wed, Dec 18, 2:51 AM
Unknown Object (File)
Thu, Nov 21, 5:44 AM
Unknown Object (File)
Nov 11 2024, 4:46 AM
Unknown Object (File)
Nov 11 2024, 4:42 AM
Unknown Object (File)
Oct 26 2024, 6:55 PM
Unknown Object (File)
Oct 26 2024, 6:55 PM
Unknown Object (File)
Oct 19 2024, 11:56 AM
Unknown Object (File)
Oct 9 2024, 7:05 PM
View All 75 Files
Subscribers
None

Details

Reviewers
atul
tomek
Commits
rCOMM2a9da4faadfd: [lib] Use Webpack 5 asset/inline instead of deprecated url-loader
Summary

See docs here and deprecation notice here.

Depends on D6701

Test Plan

I tested dev build in landing and web (we only use this plugin in dev builds) via yarn dev in landing + web + keyserver and then tested the website

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

ashoat created this revision.Feb 12 2023, 6:54 PM
ashoat added a child revision: D6703: [lib][web][landing] Update Wagmi and RainbowKit.Feb 12 2023, 7:00 PM
Harbormaster returned this revision to the author for changes because remote builds failed.Feb 12 2023, 7:04 PM
Harbormaster failed remote builds in B16354: Diff 22356!
ashoat requested review of this revision.Feb 12 2023, 7:21 PM

Please ignore failing CI – it's intentional, otherwise this diff would be too big and difficult to review

atul accepted this revision.Feb 12 2023, 7:36 PM
This revision is now accepted and ready to land.Feb 12 2023, 7:36 PM
This revision was landed with ongoing or failed builds.Feb 12 2023, 8:08 PM
Closed by commit rCOMM2a9da4faadfd: [lib] Use Webpack 5 asset/inline instead of deprecated url-loader (authored by ashoat). · Explain Why
This revision was automatically updated to reflect the committed changes.
ashoat added a commit: rCOMM2a9da4faadfd: [lib] Use Webpack 5 asset/inline instead of deprecated url-loader.

Revision Contents
Changeset List

PathSize
landing/
1 line
lib/
webpack/
4 lines
web/
1 line
13 lines

Diff 22356

View Options

landing/package.json

Loading...
View Options

lib/webpack/shared.cjs

Loading...
View Options

web/package.json

Loading...
View Options

yarn.lock

Loading...