Update to Webpack 5
ClosedPublic
Actions

Authored by ashoat on Feb 12 2023, 6:47 PM.

Details

Reviewers

atul
tomek

Commits

rCOMM9d946bde0a68: Update to Webpack 5

Summary

I followed the official docs to update to Webpack 5. Details will be explained inline.

Depends on D6698

Test Plan

I tested dev build in web via yarn dev in web + keyserver and then tested the website
I tested prod build by running yarn prod in web and then tested the website by running keyserver with yarn prod-build && yarn-prod
I tested native, just in case

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Harbormaster returned this revision to the author for changes because remote builds failed.Feb 12 2023, 6:59 PM

Please ignore failing CI – it's intentional, otherwise this diff would be too big and difficult to review

keyserver/src/responders/landing-handler.js
99 ↗	(On Diff #22353)	After updating to Webpack 5, this appears to be how we need to access a Webpack-built `commonjs` bundle from ESM code
keyserver/src/responders/website-responders.js
111 ↗	(On Diff #22353)	After updating to Webpack 5, this appears to be how we need to access a Webpack-built `commonjs` bundle from ESM code
landing/webpack.config.cjs
17 ↗	(On Diff #22353)	From upgrade guide: When using `[hash]` placeholder in webpack configuration, consider changing it to `[contenthash]`. It is not the same, but proven to be more effective.
lib/webpack/shared.cjs
19 ↗	(On Diff #22353)	From upgrade guide: When using `[hash]` placeholder in webpack configuration, consider changing it to `[contenthash]`. It is not the same, but proven to be more effective.
web/webpack.config.cjs
28 ↗	(On Diff #22353)	From upgrade guide: When using `[hash]` placeholder in webpack configuration, consider changing it to `[contenthash]`. It is not the same, but proven to be more effective.
36–38 ↗	(On Diff #22353)	For context on why I was comfortable adding empty objects for `crypto` and `path`, see the investigation on this Linear task
37 ↗	(On Diff #22353)	This got migrated to `fs: false` on the right