[Keyserver] Move shared identity client resources to lib.rs
ClosedPublic
Actions

Authored by • jon on Feb 20 2023, 1:41 PM.

Details

Reviewers

varun
bartek
• max

Commits

rCOMM053c9fc02762: [Keyserver] Move shared identity client resources to lib.rs

Summary

Refactor non-endpoint specific items to root of lib.rs.
This is to help with reviewing functional changes later.

Part of https://linear.app/comm/issue/ENG-2764

Depends on D6788

Test Plan

cd keyserver/addons/rust-node-addon
cargo build

This gets end-to-end tested later

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

• jon created this revision.Feb 20 2023, 1:41 PM

Herald added subscribers: atul, tomek, ashoat. · View Herald TranscriptFeb 20 2023, 1:41 PM

Harbormaster completed remote builds in B16642: Diff 22753.Feb 20 2023, 1:56 PM

• jon requested review of this revision.Feb 20 2023, 1:56 PM

• jon added a child revision: D6790: [Keyserver/rust-addon] Call identity deleteUser on account deletion.Feb 20 2023, 1:58 PM

varun accepted this revision.Feb 21 2023, 10:00 AM

This revision is now accepted and ready to land.Feb 21 2023, 10:00 AM

Rebase on master

Harbormaster completed remote builds in B16738: Diff 22895.Feb 21 2023, 1:52 PM

Closed by commit rCOMM053c9fc02762: [Keyserver] Move shared identity client resources to lib.rs (authored by • jon). · Explain WhyFeb 22 2023, 4:26 PM

This revision was automatically updated to reflect the committed changes.

• jon added a commit: rCOMM053c9fc02762: [Keyserver] Move shared identity client resources to lib.rs.

Revision Contents
Changeset List

Path

Size

keyserver/

addons/

rust-node-addon/

src/

identity_client.rs

42 lines

lib.rs

12 lines

Diff 22753

View Options

keyserver/addons/rust-node-addon/src/identity_client.rs