Page MenuHomePhabricator
Differential D6795

[lib] Make text and media message types read-only
ClosedPublic
Actions

Authored by ashoat on Feb 20 2023, 5:32 PM.
Tags
None
Referenced Files
F3860152: D6795.id.diff
Wed, Jan 22, 2:17 AM
F3858292: D6795.id22781.diff
Wed, Jan 22, 12:03 AM
F3858252: D6795.id.diff
Tue, Jan 21, 11:49 PM
F3858239: D6795.diff
Tue, Jan 21, 11:40 PM
F3855838: D6795.diff
Tue, Jan 21, 8:06 PM
Unknown Object (File)
Tue, Jan 21, 6:44 AM
Unknown Object (File)
Tue, Jan 14, 1:18 AM
Unknown Object (File)
Sat, Jan 11, 6:26 PM
View All 100 Files
Subscribers
tomek

Details

Reviewers
atul
Commits
rCOMM07550fb6dc2e: [lib] Make text and media message types read-only
Summary

Was updating these types and figured it would be good to make them read-only.

Test Plan

Flow. Also I tested this whole stack as follows:

  1. Create a sidebar by sending a text message on web
  2. Create a sidebar by sending a media message on web
  3. Create a sidebar by sending a text message on native
  4. Create a sidebar by sending a media message on native

In all of these cases, I confirmed that only one notif was delivered (the notif for the text/media message was skipped)

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Revision Contents
Changeset List

PathSize
keyserver/
src/
responders/
4 lines
lib/
shared/
9 lines
messages/
24 lines
22 lines
types/
messages/
28 lines
28 lines
28 lines

Diff 22781

View Options

keyserver/src/responders/message-responders.js

Loading...
View Options

lib/shared/message-utils.js

Loading...
View Options

lib/shared/messages/multimedia-message-spec.js

Loading...
View Options

lib/shared/messages/text-message-spec.js

Loading...
View Options

lib/types/messages/images.js

Loading...
View Options

lib/types/messages/media.js

Loading...
View Options

lib/types/messages/text.js

Loading...