Page MenuHomePhabricator

[lib] Add sidebarCreation flag to text and media MessageDatas
ClosedPublic

Authored by ashoat on Feb 20 2023, 5:32 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Oct 29, 4:19 PM
Unknown Object (File)
Wed, Oct 23, 10:13 AM
Unknown Object (File)
Wed, Oct 23, 10:13 AM
Unknown Object (File)
Wed, Oct 23, 10:13 AM
Unknown Object (File)
Fri, Oct 18, 3:27 AM
Unknown Object (File)
Sep 30 2024, 4:20 AM
Unknown Object (File)
Sep 30 2024, 4:20 AM
Unknown Object (File)
Sep 30 2024, 4:19 AM
Subscribers

Details

Summary

This flag won't be passed on through to the RawMessageInfo. Instead, it's used by keyserver code that calls createMessages to be able to affect notification behavior deeper in the callstack.

More details in ENG-3041.

Depends on D6795

Test Plan

I tested this whole stack as follows:

  1. Create a sidebar by sending a text message on web
  2. Create a sidebar by sending a media message on web
  3. Create a sidebar by sending a text message on native
  4. Create a sidebar by sending a media message on native

In all of these cases, I confirmed that only one notif was delivered (the notif for the text/media message was skipped)

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage