Page MenuHomePhabricator

[lib][native][web] Set sidebarCreation flag when creating messages that triggered a sidebar
ClosedPublic

Authored by ashoat on Feb 20 2023, 5:34 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Jan 14, 1:18 AM
Unknown Object (File)
Tue, Jan 7, 10:42 AM
Unknown Object (File)
Mon, Jan 6, 10:05 PM
Unknown Object (File)
Mon, Jan 6, 10:05 PM
Unknown Object (File)
Mon, Jan 6, 10:04 PM
Unknown Object (File)
Mon, Jan 6, 10:00 PM
Unknown Object (File)
Mon, Jan 6, 3:15 PM
Unknown Object (File)
Mon, Jan 6, 3:15 PM
Subscribers

Details

Summary

This is the final diff in the stack. We set sidebarCreation on the client, which makes it so notifs aren't sent by the keyserver.

Depends on D6799

Test Plan

I tested this whole stack as follows:

  1. Create a sidebar by sending a text message on web
  2. Create a sidebar by sending a media message on web
  3. Create a sidebar by sending a text message on native
  4. Create a sidebar by sending a media message on native

In all of these cases, I confirmed that only one notif was delivered (the notif for the text/media message was skipped)

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage