Page MenuHomePhabricator
Differential D6799

[keyserver][lib] Add sidebarCreation to keyserver message creation endpoints
ClosedPublic
Actions

Authored by ashoat on Feb 20 2023, 5:34 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Apr 3, 8:29 AM
Unknown Object (File)
Wed, Apr 2, 3:03 PM
Unknown Object (File)
Wed, Apr 2, 3:03 PM
Unknown Object (File)
Wed, Apr 2, 3:03 PM
Unknown Object (File)
Mon, Mar 17, 3:22 AM
Unknown Object (File)
Mon, Mar 17, 3:21 AM
Unknown Object (File)
Fri, Mar 7, 9:21 PM
Unknown Object (File)
Feb 25 2025, 4:43 PM
View All Files
Subscribers
tomek

Details

Reviewers
atul
Commits
rCOMMe0b25fd939a9: [keyserver][lib] Add sidebarCreation to keyserver message creation endpoints
Summary

This makes it possible for a client to set this flag in MessageData to disable notifs.

Depends on D6798

Test Plan

I tested this whole stack as follows:

  1. Create a sidebar by sending a text message on web
  2. Create a sidebar by sending a media message on web
  3. Create a sidebar by sending a text message on native
  4. Create a sidebar by sending a media message on native

In all of these cases, I confirmed that only one notif was delivered (the notif for the text/media message was skipped)

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Revision Contents
Changeset List

PathSize
keyserver/
src/
responders/
11 lines
lib/
shared/
29 lines
types/
3 lines

Diff 22836

View Options

keyserver/src/responders/message-responders.js

Show First 20 Lines • Show All 824 Lines • ▼ Show 20 Lines blacklist: [
'lifecycleState', 'lifecycleState',
'dimensions', 'dimensions',
'draftStore', 'draftStore',
'connectivity', 'connectivity',
'deviceOrientation', 'deviceOrientation',
'frozen', 'frozen',
'threadStore', 'threadStore',
'storeLoaded', 'storeLoaded',
'connection',
], ],
debug: __DEV__, debug: __DEV__,
version: 49, version: 49,
transforms: [messageStoreMessagesBlocklistTransform, reportStoreTransform], transforms: [messageStoreMessagesBlocklistTransform, reportStoreTransform],
migrate: (createAsyncMigrate(migrations, { debug: __DEV__ }): any), migrate: (createAsyncMigrate(migrations, { debug: __DEV__ }): any),
timeout: ((__DEV__ ? 0 : undefined): number | void), timeout: ((__DEV__ ? 0 : undefined): number | void),
}; };
Show All 15 Lines
View Options

lib/shared/message-utils.js

Show First 20 Lines • Show All 824 Lines • ▼ Show 20 Lines blacklist: [
'lifecycleState', 'lifecycleState',
'dimensions', 'dimensions',
'draftStore', 'draftStore',
'connectivity', 'connectivity',
'deviceOrientation', 'deviceOrientation',
'frozen', 'frozen',
'threadStore', 'threadStore',
'storeLoaded', 'storeLoaded',
'connection',
], ],
debug: __DEV__, debug: __DEV__,
version: 49, version: 49,
transforms: [messageStoreMessagesBlocklistTransform, reportStoreTransform], transforms: [messageStoreMessagesBlocklistTransform, reportStoreTransform],
migrate: (createAsyncMigrate(migrations, { debug: __DEV__ }): any), migrate: (createAsyncMigrate(migrations, { debug: __DEV__ }): any),
timeout: ((__DEV__ ? 0 : undefined): number | void), timeout: ((__DEV__ ? 0 : undefined): number | void),
}; };
Show All 15 Lines
View Options

lib/types/message-types.js

Show First 20 Lines • Show All 824 Lines • ▼ Show 20 Lines blacklist: [
'lifecycleState', 'lifecycleState',
'dimensions', 'dimensions',
'draftStore', 'draftStore',
'connectivity', 'connectivity',
'deviceOrientation', 'deviceOrientation',
'frozen', 'frozen',
'threadStore', 'threadStore',
'storeLoaded', 'storeLoaded',
'connection',
], ],
debug: __DEV__, debug: __DEV__,
version: 49, version: 49,
transforms: [messageStoreMessagesBlocklistTransform, reportStoreTransform], transforms: [messageStoreMessagesBlocklistTransform, reportStoreTransform],
migrate: (createAsyncMigrate(migrations, { debug: __DEV__ }): any), migrate: (createAsyncMigrate(migrations, { debug: __DEV__ }): any),
timeout: ((__DEV__ ? 0 : undefined): number | void), timeout: ((__DEV__ ? 0 : undefined): number | void),
}; };
Show All 15 Lines