Page MenuHomePhabricator

[native] Fixed 'items not removed from ChatList [..]' error
ClosedPublic

Authored by kuba on Feb 16 2023, 12:34 AM.
Tags
None
Referenced Files
F3504620: D6743.id22642.diff
Fri, Dec 20, 9:43 AM
Unknown Object (File)
Mon, Dec 2, 5:59 PM
Unknown Object (File)
Sat, Nov 23, 4:43 AM
Unknown Object (File)
Thu, Nov 21, 3:21 PM
Unknown Object (File)
Thu, Nov 21, 3:20 PM
Unknown Object (File)
Thu, Nov 21, 3:20 PM
Unknown Object (File)
Thu, Nov 21, 3:20 PM
Unknown Object (File)
Thu, Nov 21, 3:20 PM
Subscribers

Details

Summary

Issue: https://linear.app/comm/issue/ENG-2235/missing-loader-error

The message should never show in the console, but it was shown if we entered not loaded almost empty chat (e.g. older than 2 weeks, with only a few messages).

Test Plan
  1. Created a new chat with 2-3 messages.
  2. Changed messages times and thread time to more than 2 weeks from now (in database).
  3. Wiped all data from the app (e.g. by logging out).
  4. Logged in and opened the created chat.
  5. Now the message doesn't show in the console, and the app work as expected.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

kuba edited the test plan for this revision. (Show Details)
kuba added a reviewer: ashoat.
kuba edited the test plan for this revision. (Show Details)
kuba added 1 blocking reviewer(s): ashoat.
Harbormaster returned this revision to the author for changes because remote builds failed.Feb 16 2023, 6:35 AM
Harbormaster failed remote builds in B16547: Diff 22642!
ashoat added inline comments.
native/chat/chat-list.react.js
159 ↗(On Diff #22642)

Let's add a comment above this

162 ↗(On Diff #22642)

Let's remove this comment

This revision is now accepted and ready to land.Feb 17 2023, 10:09 AM
kuba edited the summary of this revision. (Show Details)
kuba edited the test plan for this revision. (Show Details)

Changed comment